linux-next.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the sound-asoc tree
Date: Mon, 18 Mar 2019 11:08:06 +0100	[thread overview]
Message-ID: <7d368c6e-3816-14fb-da32-2aeb9c076db6@samsung.com> (raw)
In-Reply-To: <20190317122851.2cf734bf@canb.auug.org.au>

On 3/17/19 02:28, Stephen Rothwell wrote:
> In commit
> 
>   2b13bee38849 ("ASoC: samsung: odroid: Fix clock configuration for 44100 sample rate")
> 
> Fixes tag
> 
>   Fixes: fbeec965b8d1c ("ASoC: samsung: odroid: Fix 32000 sample rate handling")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean:
> 
>   1d22c337dc8f ("ASoC: samsung: odroid: Fix 32000 sample rate handling"


Yes, I unfortunately used erroneously hash from this -stable commit:
 

commit fbeec965b8d1ca4005f2b63f70fd6ed54a147027
Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
Date:   Wed Mar 14 17:41:13 2018 +0100

    ASoC: samsung: odroid: Fix 32000 sample rate handling
    
    [ Upstream commit 1d22c337dc8f3a25638f7262e7bcb5729a34d140 ]
    
    In case of sample rates lower than 44100 currently there is too low MCLK
    frequency set for the CODEC. Playback fails with following errors:
    
    $ speaker-test -c2 -t sine -f 1500 -l2 -r 32000
    
    Sine wave rate is 1500.0000Hz
    Rate set to 32000Hz (requested 32000Hz)
    Buffer size range from 128 to 131072
    Period size range from 64 to 65536
    Using max buffer size 131072
    Periods = 4
    Unable to set hw params for playback: Invalid argument
    Setting of hwparams failed: Invalid argument
    
    [  497.883700] max98090 1-0010: Invalid master clock frequency
    
    To fix this the I2S root clock's frequency is increased, depending
    on sampling rate.
    
    Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


-- 
Thanks,
Sylwester

  reply	other threads:[~2019-03-18 10:08 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190317012907epcas3p129240b3dcef7d974c2fea23c26a76f2a@epcas3p1.samsung.com>
2019-03-17  1:28 ` linux-next: Fixes tag needs some work in the sound-asoc tree Stephen Rothwell
2019-03-18 10:08   ` Sylwester Nawrocki [this message]
2023-11-13 20:58 Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2023-09-28 21:41 Stephen Rothwell
2022-07-19 22:22 Stephen Rothwell
2022-05-17 22:01 Stephen Rothwell
2022-04-28  0:57 Stephen Rothwell
2022-04-28  3:04 ` Tinghan Shen
2022-03-08 21:32 Stephen Rothwell
2022-03-02 21:01 Stephen Rothwell
2021-12-01 21:25 Stephen Rothwell
2021-12-02  9:29 ` Charles Keepax
2021-06-14 22:11 Stephen Rothwell
2021-05-12 22:40 Stephen Rothwell
2021-04-14 22:01 Stephen Rothwell
2020-07-29 22:04 Stephen Rothwell
2020-04-06 21:49 Stephen Rothwell
2020-03-29  0:09 Stephen Rothwell
2020-03-14 10:50 Stephen Rothwell
2020-03-16  8:21 ` Kai Vehmanen
2020-03-01  5:45 Stephen Rothwell
2020-02-24 22:30 Stephen Rothwell
2019-10-15 11:30 Stephen Rothwell
2019-10-15 11:35 ` Peter Ujfalusi
2019-08-20 22:25 Stephen Rothwell
2019-08-20 21:04 Stephen Rothwell
2019-08-20 22:27 ` Stephen Rothwell
2019-08-15 21:59 Stephen Rothwell
2019-08-15 21:34 Stephen Rothwell
2019-07-25 21:27 Stephen Rothwell
2019-07-26  6:04 ` Peter Ujfalusi
2019-07-26 12:11   ` Mark Brown
2019-07-29  5:57     ` Peter Ujfalusi
2019-07-10 16:13 Stephen Rothwell
2019-07-11  0:40 ` Tzung-Bi Shih
2019-06-30 21:49 Stephen Rothwell
2019-06-26 13:42 Stephen Rothwell
2019-05-30 22:02 Stephen Rothwell
2019-05-21 21:31 Stephen Rothwell
2019-05-17 11:12 Stephen Rothwell
2019-05-17  2:41 S.j. Wang
2019-05-16 22:34 Stephen Rothwell
2019-03-18 11:18 Stephen Rothwell
2019-03-17  1:34 Stephen Rothwell
2019-01-28 20:27 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d368c6e-3816-14fb-da32-2aeb9c076db6@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).