From: simon@mungewell.org
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: simon@mungewell.org, linux-input@vger.kernel.org,
rdunlap@xenotime.net, linux-next@vger.kernel.org,
jkosina@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS
Date: Thu, 8 Dec 2011 11:23:26 -0500 [thread overview]
Message-ID: <80063840e8a9778675e9a63db6f1d956.squirrel@host171.canaca.com> (raw)
In-Reply-To: <CANq1E4T6uoezonoaBk6agD4-6A7QMSiP0ySDPg+5r50G8LYWTA@mail.gmail.com>
>> I don't mean to be a complainer, but shouldn't the WiiMote module depend
>> on FF_MEMLESS rather than just forcing it on.
>
> I have considered that but "grep -r FF_MEMLESS" returned no other
> driver using "depend" so I decided to use "select", too.
If you look at 'Kconfig' every other driver is fragmented into a 'driver'
and 'driver_ff', it is only the 'driver_ff' bit which does the
force-feedback and all the 'drivers' would appear to work OK (as pure
input devices) with FF disabled.
Someone here will be able to comment whether that is policy, convention or
just historic....
>> Some people might not want FF_MEMLESS enabled.
>
> Why? It is a really small feature that depends only on CONFIG_INPUT.
> Just 600 lines of code. I don't see why someone who wants to enable
> the way bigger wiimote driver and HID core would bother about
> FF_MEMLESS? Why should someone want to disable the rumble-feature of
> the wiimote?
600 lines where? What's the other costs to the system when enabling the FF
code in the kernel.
> I cannot see any real use-case here. Maybe you can explain a bit more.
Again I'm not here to kick up a fuss; it just looked different from the
norm, so I was flagging it.
Simon
next prev parent reply other threads:[~2011-12-08 16:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 6:12 linux-next: Tree for Dec 7 Stephen Rothwell
2011-12-07 10:39 ` Sasha Levin
2011-12-07 19:59 ` Sasha Levin
2011-12-07 19:10 ` linux-next: Tree for Dec 7 (x86, not SMP) Randy Dunlap
2011-12-07 19:42 ` Don Zickus
2011-12-07 20:43 ` Randy Dunlap
2011-12-07 21:06 ` Don Zickus
2011-12-08 2:45 ` Randy Dunlap
2011-12-07 20:41 ` linux-next: Tree for Dec 7 (kvm) Randy Dunlap
2011-12-07 20:53 ` linux-next: Tree for Dec 7 (hid/hid-wiimote) Randy Dunlap
2011-12-07 20:33 ` [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS David Herrmann
2011-12-07 21:07 ` simon
2011-12-08 8:31 ` David Herrmann
2011-12-08 16:23 ` simon [this message]
2011-12-08 22:43 ` Sean Young
2011-12-07 21:51 ` Randy Dunlap
2011-12-11 23:27 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80063840e8a9778675e9a63db6f1d956.squirrel@host171.canaca.com \
--to=simon@mungewell.org \
--cc=dh.herrmann@googlemail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).