From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the kspp-gustavo tree
Date: Mon, 17 Aug 2020 18:46:27 -0500 [thread overview]
Message-ID: <951ad363-cac4-967e-10fd-bce8640d6d10@embeddedor.com> (raw)
In-Reply-To: <20200818093419.5362379c@canb.auug.org.au>
Hi Stephen,
On 8/17/20 18:34, Stephen Rothwell wrote:
> Hi all,
>
> After merging the kspp-gustavo tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from include/linux/compiler_types.h:65,
> from <command-line>:
> arch/powerpc/net/bpf_jit_comp64.c: In function 'bpf_jit_build_body':
> include/linux/compiler_attributes.h:214:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
> 214 | # define fallthrough __attribute__((__fallthrough__))
> | ^~~~~~~~~~~~~
> arch/powerpc/net/bpf_jit_comp64.c:847:4: note: in expansion of macro 'fallthrough'
> 847 | fallthrough;
> | ^~~~~~~~~~~
>
> Caused by commit
>
> 02b894b985cb ("treewide: Use fallthrough pseudo-keyword")
>
> I have added the following patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 18 Aug 2020 09:26:47 +1000
> Subject: [PATCH] revert part of "treewide: Use fallthrough pseudo-keyword"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
> arch/powerpc/net/bpf_jit_comp64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/net/bpf_jit_comp64.c b/arch/powerpc/net/bpf_jit_comp64.c
> index 57412af338fb..022103c6a201 100644
> --- a/arch/powerpc/net/bpf_jit_comp64.c
> +++ b/arch/powerpc/net/bpf_jit_comp64.c
> @@ -844,7 +844,7 @@ static int bpf_jit_build_body(struct bpf_prog *fp, u32 *image,
> case BPF_JMP32 | BPF_JSET | BPF_K:
> case BPF_JMP32 | BPF_JSET | BPF_X:
> true_cond = COND_NE;
> - fallthrough;
> + /* Fall through */
>
> cond_branch:
> switch (code) {
>
Thanks a lot for the patch. I will fix this up in my -next tree for
tomorrow's linux-next. :)
--
Gustavo
next prev parent reply other threads:[~2020-08-18 0:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 23:34 linux-next: build failure after merge of the kspp-gustavo tree Stephen Rothwell
2020-08-17 23:46 ` Gustavo A. R. Silva [this message]
2020-08-17 23:38 Stephen Rothwell
2020-08-18 0:06 ` Gustavo A. R. Silva
2021-09-29 23:59 Stephen Rothwell
2021-09-30 0:11 ` Gustavo A. R. Silva
2021-10-14 23:48 Stephen Rothwell
2021-10-15 0:07 ` Gustavo A. R. Silva
2021-10-15 8:02 ` Stephen Rothwell
2021-10-18 7:15 Stephen Rothwell
2021-10-18 17:13 ` Gustavo A. R. Silva
2021-10-25 1:54 ` Stephen Rothwell
2021-10-25 2:11 ` Gustavo A. R. Silva
2021-10-25 2:42 ` Steven Rostedt
2021-10-25 4:30 ` Stephen Rothwell
2021-10-25 11:35 ` Steven Rostedt
2021-10-18 8:30 Stephen Rothwell
2021-10-20 16:18 ` Gustavo A. R. Silva
2021-10-20 16:20 ` Kees Cook
2021-10-25 1:55 ` Stephen Rothwell
2021-10-25 19:19 ` Kees Cook
2021-10-25 19:31 ` Gustavo A. R. Silva
2021-10-25 19:34 ` Kees Cook
2023-11-17 0:33 Stephen Rothwell
2023-11-17 0:39 ` Gustavo A. R. Silva
2023-11-21 2:19 Stephen Rothwell
2023-11-21 16:31 ` Gustavo A. R. Silva
2023-11-21 23:15 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=951ad363-cac4-967e-10fd-bce8640d6d10@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).