From: Zenghui Yu <yuzenghui@huawei.com>
To: Marc Zyngier <maz@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure in Linus' tree
Date: Mon, 10 Feb 2020 10:00:27 +0800 [thread overview]
Message-ID: <9a5c79e4-066e-74ba-0d17-381b1e25ef12@huawei.com> (raw)
In-Reply-To: <20200209225735.3c2eacb6@why>
On 2020/2/10 6:57, Marc Zyngier wrote:
> On Sun, 9 Feb 2020 13:24:18 -0800
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> Stephen, Linus,
>
>> On Sun, Feb 9, 2020 at 1:08 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>>
>>> Just building Linus' tree, today's linux-next build (arm
>>> multi_v7_defconfig) failed like this:
>>>
>>> arm-linux-gnueabi-ld: drivers/irqchip/irq-gic-v3-its.o: in function `its_vpe_irq_domain_alloc':
>>> irq-gic-v3-its.c:(.text+0x3d50): undefined reference to `__aeabi_uldivmod'
>>>
>>> Caused by commit
>>>
>>> 4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
>
> Gniii... Sorry for the breakage.
Sorry, my bad. I'm going to set up my 32bit ARM for tests (before
sending something out in the future).
>
>>
>> Ahh. 64-bit divides without using do_div() and friends.
>>
>> Is GICv4 even relevant for 32-bit ARM?
>
> Only should someone boot a large 64bit server in 32bit mode and run VMs
> with direct injection of interrupts. And definitely not once we get rid
> of 32bit KVM.
>
> Do you mind applying the following patch on top? It fixes the breakage
> here.
>
> Thanks,
>
> M.
>
>>From d06ab34c3491d3cd191e024bf2da1eb9b8caccdd Mon Sep 17 00:00:00 2001
> From: Marc Zyngier <maz@kernel.org>
> Date: Sun, 9 Feb 2020 22:48:50 +0000
> Subject: [PATCH] irqchip/gic-v4.1: Avoid 64bit division for the sake of 32bit
> ARM
>
> In order to allow the GICv4 code to link properly on 32bit ARM,
> make sure we don't use 64bit divisions when it isn't strictly
> necessary.
>
> Fixes: 4e6437f12d6e ("irqchip/gic-v4.1: Ensure L2 vPE table is allocated at RD level")
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> ---
> drivers/irqchip/irq-gic-v3-its.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 1ee95f546cb0..83b1186ffcad 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -2444,8 +2444,8 @@ static u64 inherit_vpe_l1_table_from_rd(cpumask_t **mask)
> static bool allocate_vpe_l2_table(int cpu, u32 id)
> {
> void __iomem *base = gic_data_rdist_cpu(cpu)->rd_base;
> - u64 val, gpsz, npg;
> - unsigned int psz, esz, idx;
> + unsigned int psz, esz, idx, npg, gpsz;
> + u64 val;
> struct page *page;
> __le64 *table;
>
>
And thanks a lot for your help, Marc!
Zenghui
next prev parent reply other threads:[~2020-02-10 2:00 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 21:08 linux-next: build failure in Linus' tree Stephen Rothwell
2020-02-09 21:24 ` Linus Torvalds
2020-02-09 22:57 ` Marc Zyngier
2020-02-09 23:48 ` Linus Torvalds
2020-02-10 2:00 ` Zenghui Yu [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-27 22:01 Stephen Rothwell
2022-03-27 22:23 ` Linus Torvalds
2022-03-27 22:31 ` Linus Torvalds
2022-03-27 23:33 ` Stephen Rothwell
2021-11-05 4:54 Stephen Rothwell
2021-11-05 9:25 ` Suzuki K Poulose
2021-11-05 4:49 Stephen Rothwell
2021-09-07 1:02 Stephen Rothwell
2021-09-06 5:57 Stephen Rothwell
2021-07-14 23:50 Stephen Rothwell
2021-07-20 6:45 ` Stephen Rothwell
2021-07-20 12:11 ` Jakub Kicinski
2021-07-22 23:04 ` Stephen Rothwell
2020-11-23 7:40 Stephen Rothwell
2020-11-23 23:39 ` Michael Ellerman
2020-11-24 0:23 ` Daniel Axtens
2020-11-25 2:47 ` Michael Ellerman
2020-06-21 2:05 Stephen Rothwell
2020-04-20 11:46 linux-next: build failure in Linus tree Stephen Rothwell
2020-04-28 8:48 ` Stephen Rothwell
2020-05-18 22:20 ` Stephen Rothwell
2020-04-05 1:22 linux-next: build failure in Linus' tree Stephen Rothwell
2020-04-05 1:27 ` Stephen Rothwell
2018-10-28 22:45 Stephen Rothwell
2018-10-28 22:35 Stephen Rothwell
2018-10-28 22:45 ` Linus Torvalds
2018-10-29 1:38 ` Hangbin Liu
2018-10-29 2:17 ` David Miller
2018-06-12 2:26 Stephen Rothwell
2018-06-18 3:50 ` Stephen Rothwell
2018-02-04 22:28 Stephen Rothwell
2017-09-17 23:34 Stephen Rothwell
2016-03-27 6:06 Stephen Rothwell
2016-03-28 20:44 ` Arnaldo Carvalho de Melo
2014-11-03 4:09 Stephen Rothwell
2014-11-03 4:16 ` David Miller
2012-07-27 0:15 Stephen Rothwell
2012-07-27 0:23 ` Stephen Rothwell
2012-07-27 1:04 ` Linus Torvalds
2012-06-14 1:47 Stephen Rothwell
2012-06-14 3:06 ` Paul Mundt
2012-06-14 3:40 ` Paul Mundt
2012-06-15 0:14 ` Stephen Rothwell
2012-06-15 0:56 ` Paul Mundt
2012-06-17 23:38 ` Benjamin Herrenschmidt
2012-06-18 4:58 ` Paul Mundt
2012-06-15 9:23 ` Sedat Dilek
2012-06-15 10:15 ` Sedat Dilek
2012-06-15 8:46 ` Richard W.M. Jones
2012-06-15 11:38 ` Arnd Bergmann
2012-05-14 0:50 Stephen Rothwell
2012-05-14 6:57 ` Grant Likely
2012-05-14 8:32 ` Thomas Gleixner
2012-05-07 0:08 Stephen Rothwell
2012-05-07 0:10 ` Al Viro
2012-04-19 0:41 Stephen Rothwell
2012-01-24 0:51 Stephen Rothwell
2011-08-29 0:44 Stephen Rothwell
2011-08-29 22:32 ` Stephen Rothwell
2011-08-29 22:50 ` James Bottomley
2011-08-11 1:59 Stephen Rothwell
2011-08-11 6:43 ` Borislav Petkov
2011-05-26 1:12 Stephen Rothwell
2011-05-20 1:15 Stephen Rothwell
2011-05-20 1:19 ` Linus Torvalds
2011-03-17 23:29 Stephen Rothwell
2011-03-17 23:35 ` Luck, Tony
2011-01-14 23:40 Stephen Rothwell
2011-01-19 3:12 ` Konrad Rzeszutek Wilk
2011-01-19 4:19 ` Stephen Rothwell
2011-01-13 23:43 Stephen Rothwell
2011-01-14 1:24 ` Linus Torvalds
2011-01-14 2:17 ` Al Viro
2010-12-21 1:01 Stephen Rothwell
2010-12-21 4:47 ` Sedat Dilek
2010-10-06 0:09 Stephen Rothwell
2010-05-28 0:57 Stephen Rothwell
2010-05-28 1:09 ` Linus Torvalds
2010-05-30 0:43 ` Stephen Rothwell
2010-06-01 17:04 ` Tony Luck
2010-06-01 17:07 ` Linus Torvalds
2010-05-24 0:40 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a5c79e4-066e-74ba-0d17-381b1e25ef12@huawei.com \
--to=yuzenghui@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).