From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
dlos <davinci-linux-open-source@linux.davincidsp.com>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH 3/3] [media] vpif: Fix compilation with allmodconfig
Date: Tue, 9 Sep 2014 19:30:58 +0100 [thread overview]
Message-ID: <CA+V-a8vXAWyRo+-LuEhMNfn1KWDfvy38pROYspPmRBckbFpj7A@mail.gmail.com> (raw)
In-Reply-To: <c522bdd8972633e0eb481ffc5ebb7da98b190fa7.1410273306.git.m.chehab@samsung.com>
On Tue, Sep 9, 2014 at 3:38 PM, Mauro Carvalho Chehab
<m.chehab@samsung.com> wrote:
> When vpif is compiled as module, those errors happen:
>
> ERROR: "vpif_lock" [drivers/media/platform/davinci/vpif_display.ko] undefined!
> ERROR: "vpif_lock" [drivers/media/platform/davinci/vpif_capture.ko] undefined!
>
> That's because vpif_lock symbol is not exported.
>
Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Regards,
--Prabhakar Lad
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
>
> diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
> index cd08e5248387..3dad5bd7fe0a 100644
> --- a/drivers/media/platform/davinci/vpif.c
> +++ b/drivers/media/platform/davinci/vpif.c
> @@ -38,6 +38,7 @@ MODULE_LICENSE("GPL");
> #define VPIF_CH3_MAX_MODES 2
>
> spinlock_t vpif_lock;
> +EXPORT_SYMBOL_GPL(vpif_lock);
>
> void __iomem *vpif_base;
> EXPORT_SYMBOL_GPL(vpif_base);
> --
> 1.9.3
>
next prev parent reply other threads:[~2014-09-09 18:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 2:43 linux-next: build failure after merge of the v4l-dvb tree Stephen Rothwell
2014-09-09 3:05 ` Mauro Carvalho Chehab
2014-09-09 14:38 ` [PATCH 1/3] omap-dma: Allow compile-testing omap1_camera driver Mauro Carvalho Chehab
2014-09-09 14:38 ` [PATCH 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST Mauro Carvalho Chehab
2014-09-09 14:58 ` Sylwester Nawrocki
2014-09-09 15:09 ` Mauro Carvalho Chehab
2014-09-09 15:30 ` Jacek Anaszewski
2014-09-09 16:10 ` [PATCHv2 " Mauro Carvalho Chehab
2014-09-09 17:10 ` Sylwester Nawrocki
2014-09-09 17:19 ` Fabio Estevam
2014-09-09 17:54 ` [PATCH " Arnd Bergmann
2014-09-09 18:40 ` Mauro Carvalho Chehab
[not found] ` <6cbd00c5f2d342b573aaf9c0e533778374dd2e1e.1410273306.git.m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-09 14:38 ` [PATCH 3/3] [media] vpif: Fix compilation with allmodconfig Mauro Carvalho Chehab
2014-09-09 18:30 ` Prabhakar Lad [this message]
2014-09-09 14:40 ` [PATCH 1/3] omap-dma: Allow compile-testing omap1_camera driver Nishanth Menon
2014-09-09 14:58 ` Tony Lindgren
2014-09-09 14:41 ` Russell King - ARM Linux
2014-09-09 15:36 ` Mauro Carvalho Chehab
2014-09-09 17:52 ` Mauro Carvalho Chehab
2014-09-10 16:25 ` Tony Lindgren
2014-09-11 10:45 ` Russell King - ARM Linux
2014-09-09 18:54 ` [PATCHv3 1/3] [media] disable OMAP1 COMPILE_TEST Mauro Carvalho Chehab
2014-09-09 18:54 ` [PATCHv3 2/3] [media] s5p-jpeg: Fix compilation with COMPILE_TEST Mauro Carvalho Chehab
2014-09-09 18:54 ` [PATCHv3 3/3] [media] vpif: Fix compilation with allmodconfig Mauro Carvalho Chehab
2014-09-09 20:36 ` [PATCHv3 1/3] [media] disable OMAP1 COMPILE_TEST Guennadi Liakhovetski
2014-09-10 8:04 ` Bartlomiej Zolnierkiewicz
2014-09-10 8:19 ` Bartlomiej Zolnierkiewicz
2014-09-17 3:47 ` linux-next: build failure after merge of the v4l-dvb tree Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+V-a8vXAWyRo+-LuEhMNfn1KWDfvy38pROYspPmRBckbFpj7A@mail.gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mchehab@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).