From: Bjorn Helgaas <bjorn.helgaas@gmail.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the pci tree
Date: Tue, 31 Mar 2020 10:32:26 -0500 [thread overview]
Message-ID: <CABhMZUUFjiw3Xpmpe2e_D2SbH+z0SwqiX5sisUFRupbHk2320g@mail.gmail.com> (raw)
In-Reply-To: <20200331033232.27ifep6igs45xv75@wunner.de>
On Mon, Mar 30, 2020 at 10:32 PM Lukas Wunner <lukas@wunner.de> wrote:
> On Tue, Mar 31, 2020 at 05:14:58AM +0200, Lukas Wunner wrote:
> > On Mon, Mar 30, 2020 at 03:53:29PM -0500, Bjorn Helgaas wrote:
> > > On Mon, Mar 30, 2020 at 3:39 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote> > In commit
> > > >
> > > > fb3ffadca55a ("PCI: pciehp: Fix indefinite wait on sysfs requests")
> > > >
> > > > Fixes tag
> > > >
> > > > Fixes: 54ecb8f7028c ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> > > >
> > > > has these problem(s):
> > > >
> > > > - Subject does not match target commit subject
> > > > Just use
> > > > git log -1 --format='Fixes: %h ("%s")'
> > > >
> > > > Did you mean
> > > >
> > > > (probably not :-))
> > > > Fixes: 54ecb8f7028c ("Linux 5.4-rc1")
> > > >
> > > > or
> > > >
> > > > Fixes: 157c1062fcd8 ("PCI: pciehp: Avoid returning prematurely from sysfs requests")
> > >
> > > Fixed, thanks!
> >
> > Ugh, sorry about that.
> >
> > In case you're not aware, it's only fixed on your next branch,
> > not on the pci/hotplug branch.
>
> Also, the incorrect commit hash is repeated further up in the commit
> message: "This flag, which was introduced by commit 54ecb8f7028c"
Thanks, I fixed that, too, and pushed my -next branch. It's fixed on
my local pci/hotplug branch, but I didn't bother pushing that branch
because it doesn't need to be build-tested and it doesn't matter for
any future hotplug patches.
Bjorn
next prev parent reply other threads:[~2020-03-31 15:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 20:38 linux-next: Fixes tag needs some work in the pci tree Stephen Rothwell
2020-03-30 20:53 ` Bjorn Helgaas
2020-03-31 3:14 ` Lukas Wunner
2020-03-31 3:32 ` Lukas Wunner
2020-03-31 15:32 ` Bjorn Helgaas [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-15 21:14 Stephen Rothwell
2023-01-16 3:23 ` Alexey V. Vissarionov
2023-01-18 17:06 ` Bjorn Helgaas
2020-11-22 9:55 Stephen Rothwell
2020-11-22 15:13 ` Bjorn Helgaas
2020-07-22 0:33 Stephen Rothwell
2019-06-22 13:40 Stephen Rothwell
2019-06-26 10:00 ` Lorenzo Pieralisi
2019-06-26 14:51 ` Bharat Kumar Gogada
2019-02-12 23:03 Stephen Rothwell
2019-02-13 9:55 ` Lorenzo Pieralisi
2019-02-13 14:31 ` Bjorn Helgaas
2019-02-13 20:09 ` Stephen Rothwell
2019-02-13 20:19 ` Bjorn Helgaas
2019-02-13 21:17 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABhMZUUFjiw3Xpmpe2e_D2SbH+z0SwqiX5sisUFRupbHk2320g@mail.gmail.com \
--to=bjorn.helgaas@gmail.com \
--cc=bjorn@helgaas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).