From: Rob Clark <robdclark@gmail.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Dave Airlie <airlied@linux.ie>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Haowen Bai <baihaowen@meizu.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
DRI <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Clark <robdclark@chromium.org>
Subject: Re: linux-next: Fixes tag needs some work in the drm tree
Date: Fri, 3 Jun 2022 07:58:14 -0700 [thread overview]
Message-ID: <CAF6AEGtYS1LYowjf-OiN-C1+4JFTWwOOpP__4iDLo-dFy0t0Tg@mail.gmail.com> (raw)
In-Reply-To: <20220603151600.19cfa617@canb.auug.org.au>
On Thu, Jun 2, 2022 at 10:16 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> In commit
>
> 8caad14e7224 ("drm/msm/dpu: Fix pointer dereferenced before checking")
>
> Fixes tag
>
> Fixes: d7d0e73f7de33 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Fixes tags should not be truncated or split across more than 1 line. So:
>
> Fixes: d7d0e73f7de3 ("drm/msm/dpu: introduce the dpu_encoder_phys_* for writeback")
Hmm, checkpatch seems to not catch this (unless it was a recent
addition that landed after what msm-fixes is based on.
will the truncated subject confuse the scripts that look for patches
to backport to stable, ie. do we *really* have to rewrite history to
fix this?
BR,
-R
next prev parent reply other threads:[~2022-06-03 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 5:16 linux-next: Fixes tag needs some work in the drm tree Stephen Rothwell
2022-06-03 14:58 ` Rob Clark [this message]
2022-06-04 0:37 ` Stephen Rothwell
2022-06-04 1:12 ` Rob Clark
-- strict thread matches above, loose matches on Subject: below --
2022-09-11 22:54 Stephen Rothwell
2022-07-12 11:27 Stephen Rothwell
2019-10-27 20:23 Stephen Rothwell
2019-10-28 4:09 ` S, Shirish
2019-07-19 8:41 Stephen Rothwell
2019-03-04 8:09 Stephen Rothwell
2019-02-04 5:50 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF6AEGtYS1LYowjf-OiN-C1+4JFTWwOOpP__4iDLo-dFy0t0Tg@mail.gmail.com \
--to=robdclark@gmail.com \
--cc=airlied@linux.ie \
--cc=baihaowen@meizu.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@chromium.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).