From: Kees Cook <keescook@chromium.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: James Morris <jmorris@namei.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the security tree
Date: Wed, 16 Aug 2017 20:24:24 -0700 [thread overview]
Message-ID: <CAGXu5j+RQDASj+pVSxv5tN7p071qfgtvqh3atjmb=0akXJwVHw@mail.gmail.com> (raw)
In-Reply-To: <20170817125140.7d705af8@canb.auug.org.au>
On Wed, Aug 16, 2017 at 7:51 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi James,
>
> After merging the security tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from samples/seccomp/bpf-fancy.c:12:0:
> samples/seccomp/bpf-fancy.c: In function 'main':
> samples/seccomp/bpf-helper.h:47:26: error: 'SECCOMP_RET_KILL_THREAD' undeclared (first use in this function)
> BPF_STMT(BPF_RET+BPF_K, SECCOMP_RET_KILL_THREAD)
> ^
> ./usr/include/linux/filter.h:48:59: note: in definition of macro 'BPF_STMT'
> #define BPF_STMT(code, k) { (unsigned short)(code), 0, 0, k }
> ^
> samples/seccomp/bpf-fancy.c:41:3: note: in expansion of macro 'DENY'
> DENY, /* Don't passthrough into a label */
> ^~~~
> samples/seccomp/bpf-helper.h:47:26: note: each undeclared identifier is reported only once for each function it appears in
> BPF_STMT(BPF_RET+BPF_K, SECCOMP_RET_KILL_THREAD)
> ^
> ./usr/include/linux/filter.h:48:59: note: in definition of macro 'BPF_STMT'
> #define BPF_STMT(code, k) { (unsigned short)(code), 0, 0, k }
> ^
> samples/seccomp/bpf-fancy.c:41:3: note: in expansion of macro 'DENY'
> DENY, /* Don't passthrough into a label */
> ^~~~
>
> [Note: this is a cross build, if that is relevant ...]
>
> Presumably caused by commit
>
> fd76875ca289 ("seccomp: Rename SECCOMP_RET_KILL to SECCOMP_RET_KILL_THREAD")
>
> I have used the security tree from next-20170816 for today.
Hmmm, I think we've had problems like this before due to samples being
built before the headers have been installed. Regardless, I'll
un-rename that macro in the samples...
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-08-17 3:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 2:51 linux-next: build failure after merge of the security tree Stephen Rothwell
2017-08-17 3:24 ` Kees Cook [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-08 4:00 Stephen Rothwell
2020-07-13 2:04 ` Stephen Rothwell
2020-07-13 2:06 ` Stephen Rothwell
2020-07-29 23:35 ` Stephen Rothwell
2020-07-30 2:35 ` James Morris
2020-07-30 2:59 ` Stephen Rothwell
2020-07-30 5:03 ` Stephen Rothwell
2020-08-04 3:36 ` James Morris
2019-08-12 4:58 Stephen Rothwell
2019-08-12 17:34 ` Kees Cook
2019-08-19 3:21 ` Stephen Rothwell
2019-08-19 3:38 ` Stephen Rothwell
2019-08-21 16:39 ` James Morris
2017-08-23 11:12 Stephen Rothwell
2016-05-19 4:01 Stephen Rothwell
[not found] ` <20160519140120.23b345a1-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>
2016-05-19 10:11 ` David Howells
2016-05-19 23:14 ` Stephen Rothwell
2016-05-20 3:07 ` Steve French
2015-08-17 5:29 Stephen Rothwell
2015-08-17 6:04 ` Stephen Rothwell
2015-08-26 14:45 ` David Howells
2014-07-25 9:21 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5j+RQDASj+pVSxv5tN7p071qfgtvqh3atjmb=0akXJwVHw@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).