From: Suren Baghdasaryan <surenb@google.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the origin tree
Date: Sun, 16 Jan 2022 17:27:34 -0800 [thread overview]
Message-ID: <CAJuCfpErqDrgEkw7OXyGTkfXiAEDHx=9DF9cW0qdc27Nm1_wrw@mail.gmail.com> (raw)
In-Reply-To: <20220117114514.5b6daa04@canb.auug.org.au>
On Sun, Jan 16, 2022 at 4:45 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the origin tree, today's linux-next build (powerpc
> allnoconfig) produced this warning:
>
> kernel/sysctl.c:125:12: warning: 'one_thousand' defined but not used [-Wunused-variable]
> 125 | static int one_thousand = 1000;
> | ^~~~~~~~~~~~
>
> Introduced by commit
>
> 39c65a94cd96 ("mm/pagealloc: sysctl: change watermark_scale_factor max limit to 30%")
>
> It seems to only be used when CONFIG_PERF_EVENTS is set.
>
> I didn't see it in linux-next because there is a patch later in the
> akpm series (not yet in Linus' tree) that removes this variable.
Sorry, I saw the warning before when backporting this patch but I
didn't realize that the followup patches refactoring this code would
not be merged.
Posted a fix at:
https://lore.kernel.org/all/20220117012317.21168-1-surenb@google.com/
Thanks!
>
> --
> Cheers,
> Stephen Rothwell
next prev parent reply other threads:[~2022-01-17 1:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 0:45 linux-next: build warning after merge of the origin tree Stephen Rothwell
2022-01-17 1:27 ` Suren Baghdasaryan [this message]
2022-01-17 2:24 ` Stephen Rothwell
2022-01-17 22:01 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2024-03-25 1:17 Stephen Rothwell
2021-01-06 22:05 Stephen Rothwell
2021-01-06 22:23 ` Johannes Berg
2021-01-06 22:44 ` Stephen Rothwell
2021-01-06 22:46 ` Johannes Berg
2021-01-06 23:20 ` Stephen Rothwell
2019-11-27 20:59 Stephen Rothwell
2019-11-28 8:11 ` Linus Walleij
2012-05-14 0:44 Stephen Rothwell
2012-05-14 3:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpErqDrgEkw7OXyGTkfXiAEDHx=9DF9cW0qdc27Nm1_wrw@mail.gmail.com' \
--to=surenb@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).