From: Shakeel Butt <shakeelb@google.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Roman Gushchin <guro@fb.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>,
Juergen Christ <jchrist@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>, Linux MM <linux-mm@kvack.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [BUG -next] "memcg: charge before adding to swapcache on swapin" broken
Date: Tue, 16 Mar 2021 14:21:29 -0700 [thread overview]
Message-ID: <CALvZod5ju+rWRNtVTjka0PgOPTrWnQ0mStaVEi2wEYEZEprBiA@mail.gmail.com> (raw)
In-Reply-To: <YFEeWD7LMPYngtbA@osiris>
Hi Heiko,
On Tue, Mar 16, 2021 at 2:08 PM Heiko Carstens <hca@linux.ibm.com> wrote:
>
> Hi Shakeel,
>
> your commit 3a9ca1b0ac0f ("memcg: charge before adding to swapcache on
> swapin") in linux-next 20210316 appears to cause user process faults /
> crashes on s390 like:
>
> User process fault: interruption code 003b ilc:3 in sshd[2aa15280000+df000]
> Failing address: 0000000000000000 TEID: 0000000000000800
> Fault in primary space mode while using user ASCE.
> AS:00000000966b41c7 R3:0000000000000024
> CPU: 0 PID: 401 Comm: sshd Not tainted 5.12.0-rc3-00048-geba7667a8534 #10
> Hardware name: IBM 8561 T01 703 (z/VM 7.2.0)
> User PSW : 0705000180000000 0000000000000000
> R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:1 AS:0 CC:0 PM:0 RI:0 EA:3
> User GPRS: 0000000000000000 fffffffffffff000 0000000000000001 000002aa157b88f0
> 000002aa157c43c0 0000000000000000 0000000000000000 0000000000000000
> 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> User Code: Bad PSW.
>
Thanks for the report. Can you please explain a bit what the above report tells?
I will try the following on the machines I have with that patch.
> This was bisected using elfutils selftests:
>
> autoreconf -fi
> ./configure --enable-maintainer-mode --disable-debuginfod
> make -j $(nproc)
> cd tests
> make -j $(nproc) check
next prev parent reply other threads:[~2021-03-16 21:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 21:08 [BUG -next] "memcg: charge before adding to swapcache on swapin" broken Heiko Carstens
2021-03-16 21:21 ` Shakeel Butt [this message]
2021-03-17 0:46 ` Heiko Carstens
2021-03-17 8:36 ` Christian Borntraeger
2021-03-17 13:33 ` Shakeel Butt
2021-03-17 15:26 ` Heiko Carstens
2021-03-17 15:44 ` Shakeel Butt
2021-03-17 20:44 ` Heiko Carstens
2021-03-17 21:11 ` Heiko Carstens
2021-03-17 21:39 ` Shakeel Butt
2021-03-18 0:23 ` Shakeel Butt
2021-03-18 1:30 ` Minchan Kim
2021-03-18 1:49 ` Shakeel Butt
2021-03-18 15:19 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod5ju+rWRNtVTjka0PgOPTrWnQ0mStaVEi2wEYEZEprBiA@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hca@linux.ibm.com \
--cc=hughd@google.com \
--cc=jchrist@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).