From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBF2C433F5 for ; Mon, 20 Dec 2021 12:45:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231407AbhLTMpC (ORCPT ); Mon, 20 Dec 2021 07:45:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230209AbhLTMpB (ORCPT ); Mon, 20 Dec 2021 07:45:01 -0500 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83768C061574 for ; Mon, 20 Dec 2021 04:45:01 -0800 (PST) Received: by mail-yb1-xb35.google.com with SMTP id d10so28534417ybn.0 for ; Mon, 20 Dec 2021 04:45:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bymUVH7dKBh7uCkZZEUVVQY6d2Jlj4KY+YLiw5M1EeQ=; b=AKpLCtabjvqSUU+xr4cjPZd3vtcZlzKWOfawBgGQHza73eWLnwyguyGj8VkBKkU/gt hKdavF3uNDsLXZbwLX1B68pl3/97PbSZDRoQ5DzaIeYDr9f8yQB5uPyABLHkWcglQVWX Bk0V6ac0gnE02Dvg8itMiL1MTG3tS0GGoYUF9NNeMHlkgZOBWkxSGqFGYPQy+HQ8EjwI m4efEYEUYvSsxNY60UMwKFZGxkWqEvwa5m89uLjOyubbD6IGTv0t/rOTsVQOUNvPg4QX AuYQID+9B0tGYDKEwShzTNVfV05Ua5u1Fb49ttRlurEohmNzeJJOlI/AfZ/i5MngaiUa GlDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bymUVH7dKBh7uCkZZEUVVQY6d2Jlj4KY+YLiw5M1EeQ=; b=cIrCLSIhwlqpoV1ARD1kbJLNIxZrQRJRapTX2hxwp4ZBLwehnFBFeq+TU2CsP6qTgE saEYHTnRu4qYhSgb3pdWQ/S3TiLOyIz9KBsARxtGkEumtr+Zb/Ogq12v7EJxCtm3N3gM q/Gs/v2p0ypjspGovABZSHca6lb2CxsyQzlqJspbs7zg9/c+FKuWugGK7DyRSCfL8qbS mQRN1A0u6lqtj2Q1Z0qOMYvlfQsaTID2Jmbs1UwZK/yPQ1v8op53s8rnux1AAORwIL6g Zw+lZmiR6NvwrECWCKcdXgVpaf+q6hVNC3fbrUGbLvnvceT6hSfhidq8S9JvCQMDg2Ob yUGQ== X-Gm-Message-State: AOAM532x313xI6cc5naLZmVp9Wwj80lykGcXFgTZ7wug+zypB4jBbI8I iyOhF/OqHBp/pcs3QomnObThR/tfjHJB2/7JR5gjiQ== X-Google-Smtp-Source: ABdhPJz/+WopWTog4ZtWYhnbiRxpAv7NDiRobRdqX/jKXBOCt6J4IbzAgSM6hlVmNaZGYuqY3Dy6DTneH0URBfk2qu0= X-Received: by 2002:a25:d685:: with SMTP id n127mr21284381ybg.523.1640004300820; Mon, 20 Dec 2021 04:45:00 -0800 (PST) MIME-Version: 1.0 References: <20211220220843.735da08f@canb.auug.org.au> In-Reply-To: <20211220220843.735da08f@canb.auug.org.au> From: Muchun Song Date: Mon, 20 Dec 2021 20:44:22 +0800 Message-ID: Subject: Re: linux-next: build failure after merge of the akpm tree To: Stephen Rothwell Cc: Andrew Morton , Guenter Roeck , Armin Wolf , Linux Kernel Mailing List , Linux Next Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-next@vger.kernel.org On Mon, Dec 20, 2021 at 7:08 PM Stephen Rothwell wrote: > > Hi all, > > After merging the akpm tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_ioctl': > drivers/hwmon/dell-smm-hwmon.c:454:31: error: implicit declaration of function 'PDE_DATA'; did you mean 'NODE_DATA'? [-Werror=implicit-function-declaration] > 454 | struct dell_smm_data *data = PDE_DATA(file_inode(fp)); > | ^~~~~~~~ > | NODE_DATA > drivers/hwmon/dell-smm-hwmon.c:454:31: error: initialization of 'struct dell_smm_data *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion] > cc1: all warnings being treated as errors > > Caused by commit > > 2dd082773083 ("proc: remove PDE_DATA() completely") > > interacting with commit > > 073bd07205af ("hwmon: (dell-smm) Unify i8k_ioctl() and i8k_ioctl_unlocked()") > > from the hwmon-staging tree. > > I applied the following fixup patch. > > From: Stephen Rothwell > Date: Mon, 20 Dec 2021 22:04:57 +1100 > Subject: [PATCH] fixup for "proc: remove PDE_DATA() completely" > > Signed-off-by: Stephen Rothwell Thanks Stephen. Reviewed-by: Muchun Song