From: Marco Elver <elver@google.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: David Sterba <dsterba@suse.cz>,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: linux-next: Tree for Dec 6 (objtool, lots in btrfs)
Date: Fri, 17 Jan 2020 21:28:27 +0100 [thread overview]
Message-ID: <CANpmjNP6Q5-uOVi5TvbnHKbHkubqrbzW1+QZqvoEVty6X7ZDXw@mail.gmail.com> (raw)
In-Reply-To: <20200117172629.yqowxl642hdx4vcm@treble>
On Fri, 17 Jan 2020 at 18:26, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> On Tue, Dec 17, 2019 at 04:25:11PM +0100, David Sterba wrote:
> > On Fri, Dec 13, 2019 at 11:05:18PM -0800, Randy Dunlap wrote:
> > > OK, that fixes most of them, but still leaves these 2:
> > >
> > > btrfs006.out:fs/btrfs/extent_io.o: warning: objtool: __set_extent_bit()+0x536: unreachable instruction
> >
> > Hard to read from the assembly what C statement is it referring to. I
> > think there are also several functions inlined, I don't see anything
> > suspicious inside __set_extent_bit itself.
> >
> > > btrfs006.out:fs/btrfs/relocation.o: warning: objtool: add_tree_block()+0x501: unreachable instruction
> >
> > Probably also heavily inlined, the function has like 50 lines, a few
> > non-trivial function calls but the offset in the warning suggests a
> > larger size.
> >
> > While browsing the callees I noticed that both have in common a function
> > that is supposed to print and stop at fatal errors. They're
> > extent_io_tree_panic (extent_io.c) and backref_tree_panic
> > (relocation.c). Both call btrfs_panic which is a macro:
> >
> > 3239 #define btrfs_panic(fs_info, errno, fmt, args...) \
> > 3240 do { \
> > 3241 __btrfs_panic(fs_info, __func__, __LINE__, errno, fmt, ##args); \
> > 3242 BUG(); \
> > 3243 } while (0)
> >
> > There are no conditionals and BUG has the __noreturn annotation
> > (unreachable()) so all is in place and I don't have better ideas what's
> > causing the reports.
>
> I think KCSAN is somehow disabling GCC's detection of implicit noreturn
> functions -- or at least some calls to them. So GCC is inserting dead
> code after the calls. BUG() uses __builtin_unreachable(), so GCC should
> know better.
>
> If this is specific to KCSAN then I might just disable these warnings
> for KCSAN configs.
I noticed that this is also a CC_OPTIMIZE_FOR_SIZE config. I recently
sent some patches to turn some inlines into __always_inlines because
CC_OPTIMIZE_FOR_SIZE decides to not inline functions that should
always be inlined.
I noticed that 'assfail' is a 'static inline' function and you
mentioned earlier that GCC seems to not be able to determine if it
returns or not. If CC_OPTIMIZE_FOR_SIZE decides to not inline, then
maybe this could be a problem? It could also be the compiler having
some trouble here with the CC_OPTIMIZE_FOR_SIZE + KCSAN combination.
Thanks,
-- Marco
next prev parent reply other threads:[~2020-01-17 20:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 2:54 linux-next: Tree for Dec 6 Stephen Rothwell
2019-12-06 10:15 ` Geert Uytterhoeven
2019-12-06 12:43 ` Stephen Rothwell
2019-12-06 16:17 ` linux-next: Tree for Dec 6 (objtool, lots in btrfs) Randy Dunlap
2019-12-11 13:49 ` David Sterba
2019-12-11 16:21 ` Randy Dunlap
2019-12-12 18:47 ` Josh Poimboeuf
2019-12-12 20:25 ` Randy Dunlap
2019-12-13 23:03 ` Randy Dunlap
2019-12-13 23:50 ` Josh Poimboeuf
2019-12-14 0:04 ` Randy Dunlap
2019-12-14 5:45 ` Josh Poimboeuf
2019-12-14 7:05 ` Randy Dunlap
2019-12-17 15:25 ` David Sterba
2020-01-17 17:26 ` Josh Poimboeuf
2020-01-17 20:28 ` Marco Elver [this message]
2020-01-17 21:26 ` Josh Poimboeuf
2020-01-17 22:22 ` Josh Poimboeuf
2019-12-17 15:29 ` David Sterba
2020-01-10 19:46 ` David Sterba
2020-01-17 15:28 ` Josh Poimboeuf
2020-01-17 16:50 ` David Sterba
2020-01-17 17:03 ` Josh Poimboeuf
2020-01-20 15:52 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANpmjNP6Q5-uOVi5TvbnHKbHkubqrbzW1+QZqvoEVty6X7ZDXw@mail.gmail.com \
--to=elver@google.com \
--cc=dsterba@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).