From: Patrick Venture <venture@google.com>
To: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: linux-next: build warning after merge of the char-misc tree
Date: Fri, 26 Apr 2019 07:30:06 -0700 [thread overview]
Message-ID: <CAO=notwQFWRVDtoH+NGWpm647pJHVFvVoPm3EKdKmdrRUmDZqw@mail.gmail.com> (raw)
In-Reply-To: <20190426062548.GB5920@kroah.com>
On Thu, Apr 25, 2019 at 11:25 PM Greg KH <greg@kroah.com> wrote:
>
> On Fri, Apr 26, 2019 at 03:56:53PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the char-misc tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > drivers/misc/aspeed-p2a-ctrl.c: In function 'aspeed_p2a_mmap':
> > drivers/misc/aspeed-p2a-ctrl.c:110:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> > pgprot_t prot = vma->vm_page_prot;
> > ^~~~~~~~
> >
> > Introduced by commit
> >
> > 01c60dcea9f7 ("drivers/misc: Add Aspeed P2A control driver")
>
> Patrick, I thought you fixed all of these already? Can you send a patch
> again?
I fixed the ones caught by the robot. I'll have to switch up my build
environment a bit to fault on warnings for the kernel, not sure why it
isn't --
>
> Can you also make the driver so it can build with CONFIG_COMPILE_TEST
> enabled so that others can find your problems earlier in the review
> process?
Roger that.
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2019-04-26 14:30 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-26 5:56 linux-next: build warning after merge of the char-misc tree Stephen Rothwell
2019-04-26 6:25 ` Greg KH
2019-04-26 14:30 ` Patrick Venture [this message]
2019-04-26 18:00 ` Patrick Venture
-- strict thread matches above, loose matches on Subject: below --
2024-04-15 5:22 Stephen Rothwell
2024-04-15 7:21 ` Greg KH
2022-07-15 11:43 Stephen Rothwell
2021-05-24 6:19 Stephen Rothwell
2021-04-06 11:44 Stephen Rothwell
2021-04-06 11:46 ` Stephen Rothwell
2021-04-06 14:07 ` Greg KH
2021-04-06 14:13 ` Gustavo Pimentel
2021-04-06 14:15 ` Greg KH
2021-04-06 17:28 ` Gustavo Pimentel
2021-04-06 17:33 ` Greg KH
2021-01-29 7:07 Stephen Rothwell
2020-05-01 6:28 Stephen Rothwell
2020-05-01 6:55 ` Greg KH
2020-05-01 10:17 ` Rajan Vaja
2018-10-02 9:12 Stephen Rothwell
2018-10-02 9:49 ` Bartosz Golaszewski
2018-10-02 9:56 ` Srinivas Kandagatla
2018-10-02 10:04 ` Bartosz Golaszewski
2018-10-02 5:31 Stephen Rothwell
2018-10-02 8:34 ` Bartosz Golaszewski
2017-12-12 3:39 Stephen Rothwell
2017-12-12 11:49 ` Greg KH
2017-07-20 4:12 Stephen Rothwell
2017-07-20 5:13 ` Greg KH
2017-07-20 14:52 ` KY Srinivasan
2017-07-20 9:14 ` Greg KH
2017-03-28 3:31 Stephen Rothwell
2017-03-28 3:58 ` Masahiro Yamada
2015-03-27 7:48 Stephen Rothwell
2015-03-31 19:35 ` Fabian Frederick
2015-04-03 14:05 ` Greg KH
2013-02-15 5:26 Stephen Rothwell
2013-02-15 17:34 ` Greg KH
2013-02-15 18:07 ` Arnd Bergmann
2013-02-15 20:05 ` Arnd Bergmann
2013-03-01 15:51 ` Sedat Dilek
2013-03-01 17:16 ` Arnd Bergmann
2013-03-01 17:43 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO=notwQFWRVDtoH+NGWpm647pJHVFvVoPm3EKdKmdrRUmDZqw@mail.gmail.com' \
--to=venture@google.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).