RE: [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a compatibility string to bindings

[Ashish Kumar <ashish.kumar@nxp.com>]

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Friday, August 23, 2019 12:35 AM
> To: Ashish Kumar <ashish.kumar@nxp.com>
> Cc: shawnguo@kernel.org; linux-kernel@vger.kernel.org; linux-
> spi@vger.kernel.org; devicetree@vger.kernel.org; robh+dt@kernel.org;
> mark.rutland@arm.com; linux-next@vger.kernel.org; Kuldeep Singh
> <kuldeep.singh@nxp.com>
> Subject: Re: [EXT] Re: [Patch v4 1/3] dt-bindings: spi: spi-fsl-qspi: Add ls2080a
> compatibility string to bindings
> 
> On Wed, Aug 21, 2019 at 02:18:43PM +0000, Ashish Kumar wrote:
> 
> Please fix your mail client to word wrap within paragraphs at something
> substantially less than 80 columns.  Doing this makes your messages much
> easier to read and reply to.
> 
> > Snippet from driver spi-fsl-qspi.c
> > static const struct of_device_id fsl_qspi_dt_ids[] = {
> >         { .compatible = "fsl,vf610-qspi", .data = &vybrid_data, },
> >         { .compatible = "fsl,imx6sx-qspi", .data = &imx6sx_data, },
> >         { .compatible = "fsl,imx7d-qspi", .data = &imx7d_data, },
> >         { .compatible = "fsl,imx6ul-qspi", .data = &imx6ul_data, },
> >         { .compatible = "fsl,ls1021a-qspi", .data = &ls1021a_data, },
> >         { .compatible = "fsl,ls2080a-qspi", .data = &ls2080a_data, },
> >         { /* sentinel */ }
> > };
> 
> > I had previously sent dts patch based out of Shawn's tree with
> > dependency on these dt binding patch. To which Shawn had replied to
> > get dependency patch accepted first before sending this dts change.
> 
> Right, there appears to be an entry for patch 1 which was added without the
> binding doc being updated - patch 2 looks to not have the compatibles in the
> driver though?
Hi Mark,

For Patch-2, I intended to use this in arm64/boot/dts/freescale/fsl-ls1088a.dtsi (please see below), since both ls1088 and ls2080 has same QSPI controller.
So I had introduced new compatible
+                "fsl,ls1012a-qspi" followed by "fsl,ls1021a-qspi"
+                "fsl,ls1088a-qspi" followed by "fsl,ls2080a-qspi"

Now the dtsi will look like this:
               qspi: spi@20c0000 {
                        compatible = "fsl,ls2080a-qspi", "fsl,ls1088a-qspi";
                        #address-cells = <1>;
                        #size-cells = <0>;
                        reg = <0x0 0x20c0000 0x0 0x10000>,
                              <0x0 0x20000000 0x0 0x10000000>;
                        reg-names = "QuadSPI", "QuadSPI-memory";
                        interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
                        clock-names = "qspi_en", "qspi";
                        clocks = <&clockgen 4 3>, <&clockgen 4 3>;
                        status = "disabled";
                };

If you think this is incorrect, then I can add this in driver
{ .compatible = "fsl,ls1088a-qspi", .data = &ls2080a_data, },

Regards
Ashish