From: Willy Tarreau <w@1wt.eu>
To: Zhangjin Wu <falcon@tinylab.org>
Cc: sfr@canb.auug.org.au, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, paulmck@kernel.org
Subject: Re: linux-next: Signed-off-by missing for commit in the rcu tree
Date: Fri, 9 Jun 2023 11:24:58 +0200 [thread overview]
Message-ID: <ZILv6qiLIVJO8+MK@1wt.eu> (raw)
In-Reply-To: <20230609040804.164292-1-falcon@tinylab.org>
On Fri, Jun 09, 2023 at 12:08:04PM +0800, Zhangjin Wu wrote:
> Hi, Stephen, Willy, Thomas, Paul
>
> > Hi all,
> >
> > Sorry, the subject should have been "linux-next: fixes tag needs work
> > in rcu tree".
> >
> > On Fri, 9 Jun 2023 08:27:22 +1000 Stephen Rothwell <sfr@canb.auug.org.au> w=
> > rote:
> > >
> > > In commit
> > >=20
> > > df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")
> > >=20
> > > Fixes tag
> > >=20
> > > Fixes: 8e3ab529bef9 ("tools/nolibc/unistd: add syscall()")
> > >=20
> > > has these problem(s):
> > >=20
> > > - Target SHA1 does not exist
> > >=20
> > > Maybe you meant
> > >=20
> > > Fixes: 6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")
>
> Thanks, just checked the rcu/next branch of Paul, the commit is really the one
> you corrected:
>
> Fixes: 6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")
>
> Willy, this happened may be because of the 'int' to 'long' fixup merged to the
> old "tools/nolibc/unistd: add syscall()" commit, I forgot the check of this
> change in my patch.
I was very careful about squashing the patches that mentioned commit IDs
that were not merged yet (since we don't want to merge incomplete patches),
but apparently missed this one :-/
> Btw, perhaps it is possible to merge this typo fixup (tools/nolibc: fix up typo
> _sycall_narg -> _syscall_narg) [1] to this commit too:
>
> 6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")
>
> And then update the new 'Fixes' tag in this patch:
>
> df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")
>
> Or even merge both of them to the first one, and eventually, no Fixes lines
> required.
>
> As a summary, the following two fixes:
>
> df772c12508a ("selftests/nolibc: syscall_args: use generic __NR_statx")
>
> not merged ("tools/nolibc: fix up typo _sycall_narg -> _syscall_narg"), see [1]
>
> are for this one:
>
> 6bff2a1e97e3 ("tools/nolibc/unistd: add syscall()")
>
> Merging both of them to the above one may be a choice ;-)
Agreed. I'll see off-line with Paul how to best proceed.
Thanks,
Willy
next prev parent reply other threads:[~2023-06-09 9:36 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 22:27 linux-next: Signed-off-by missing for commit in the rcu tree Stephen Rothwell
2023-06-08 22:28 ` Stephen Rothwell
2023-06-09 4:08 ` Zhangjin Wu
2023-06-09 9:24 ` Willy Tarreau [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-07 20:39 Stephen Rothwell
2024-02-08 16:07 ` Paul E. McKenney
2023-06-08 22:31 Stephen Rothwell
2023-06-09 19:00 ` Paul E. McKenney
2023-05-16 22:41 Stephen Rothwell
2023-05-16 22:54 ` Paul E. McKenney
2023-03-08 2:16 Stephen Rothwell
2023-03-08 17:41 ` Paul E. McKenney
2022-09-22 10:12 Stephen Rothwell
2022-09-22 13:55 ` Paul E. McKenney
2022-01-03 21:38 Stephen Rothwell
2022-01-03 23:33 ` Paul E. McKenney
2021-05-23 3:02 Stephen Rothwell
2021-05-24 3:49 ` Paul E. McKenney
2021-03-08 6:03 Stephen Rothwell
2021-03-09 5:24 ` Paul E. McKenney
2021-01-10 2:24 Stephen Rothwell
2021-01-10 5:15 ` Paul E. McKenney
2020-11-22 10:08 Stephen Rothwell
2020-11-22 10:09 ` Stephen Rothwell
2020-11-22 17:51 ` Paul E. McKenney
2020-09-29 22:37 Stephen Rothwell
2020-09-30 4:43 ` Paul E. McKenney
2020-09-17 3:26 Stephen Rothwell
2020-09-17 18:00 ` Paul E. McKenney
2020-09-22 22:35 ` Stephen Rothwell
2020-09-28 7:57 ` Peter Zijlstra
2020-09-28 17:33 ` Paul E. McKenney
2020-11-18 23:40 ` Paul E. McKenney
2020-02-12 22:25 Stephen Rothwell
2020-02-13 21:38 ` Joel Fernandes
2020-02-27 15:10 ` Paul E. McKenney
2019-10-28 20:53 Stephen Rothwell
2019-10-29 0:37 ` Paul E. McKenney
2018-04-23 21:48 Stephen Rothwell
2018-04-23 22:16 ` Paul E. McKenney
2018-02-26 22:38 Stephen Rothwell
2018-02-26 23:22 ` Paul E. McKenney
2017-11-29 0:51 Stephen Rothwell
2017-11-29 1:14 ` Paul E. McKenney
2017-11-29 2:48 ` Lihao Liang
2017-11-29 3:14 ` Hanjun Guo
2017-11-29 3:29 ` Lihao Liang
2017-11-29 20:54 ` Paul E. McKenney
2017-07-30 13:48 Stephen Rothwell
2017-07-30 16:57 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZILv6qiLIVJO8+MK@1wt.eu \
--to=w@1wt.eu \
--cc=falcon@tinylab.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).