From: David Rientjes <rientjes@google.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-arch@vger.kernel.org, Rafael Aquini <aquini@redhat.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] asm-generic: add __WARN() to bug.h
Date: Wed, 14 Nov 2012 17:28:29 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.00.1211141726380.4749@chino.kir.corp.google.com> (raw)
In-Reply-To: <50A43E5E.9040905@xenotime.net>
On Wed, 14 Nov 2012, Randy Dunlap wrote:
> --- linux-next-20121114.orig/include/asm-generic/bug.h
> +++ linux-next-20121114/include/asm-generic/bug.h
> @@ -129,6 +129,10 @@ extern void warn_slowpath_null(const cha
> })
> #endif
>
> +#ifndef __WARN
> +#define __WARN() do {} while (0)
> +#endif
> +
> #define WARN_TAINT(condition, taint, format...) WARN_ON(condition)
>
> #endif
__WARN() isn't supposed to be used by generic code, though. The
mm/balloon_compaction.c error should be resolved by
mm-introduce-a-common-interface-for-balloon-pages-mobility-fix-fix-fix.patch
added to -mm today. It converts the __WARN() there into WARN_ON(1) which
is defined appropriately for CONFIG_BUG=n.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-11-15 1:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 5:30 linux-next: Tree for Nov 14 Stephen Rothwell
2012-11-14 5:37 ` Andrew Morton
2012-11-14 5:53 ` Andrew Morton
2012-11-14 6:47 ` Ingo Molnar
2012-11-14 6:56 ` Andrew Morton
2012-11-14 7:15 ` Stephen Rothwell
2012-11-14 7:24 ` Andrew Morton
2012-11-14 7:39 ` Ingo Molnar
2012-11-14 8:13 ` Hugh Dickins
2012-11-14 17:05 ` Rik van Riel
2012-11-15 12:10 ` Mel Gorman
2012-11-14 17:19 ` Linus Torvalds
2012-11-14 6:55 ` Stephen Rothwell
2012-11-14 7:03 ` Stephen Rothwell
2012-11-14 19:41 ` linux-next: Tree for Nov 14 (gpu/drm/i915) Randy Dunlap
2012-11-14 20:17 ` Andrew Morton
2012-11-15 0:59 ` [PATCH 1/2] asm-generic: add __WARN() to bug.h Randy Dunlap
2012-11-15 1:28 ` David Rientjes [this message]
2012-11-15 0:59 ` [PATCH 2/2] mm: balloon_compaction.c needs asm-generic/bug.h Randy Dunlap
2012-11-15 1:29 ` David Rientjes
2012-11-15 1:29 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1211141726380.4749@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).