From: Kishon Vijay Abraham I <kishon@ti.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the mmc tree
Date: Thu, 15 Feb 2018 10:59:38 +0530 [thread overview]
Message-ID: <c278d6eb-8ca2-c25c-3ff9-2d62d758317d@ti.com> (raw)
In-Reply-To: <20180215114954.689cc952@canb.auug.org.au>
Hi,
On Thursday 15 February 2018 06:19 AM, Stephen Rothwell wrote:
> Hi Ulf,
>
> After merging the mmc tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_set_timing':
> drivers/mmc/host/sdhci-omap.c:466:8: error: implicit declaration of function 'pinctrl_select_state'; did you mean 'inc_node_state'? [-Werror=implicit-function-declaration]
> ret = pinctrl_select_state(omap_host->pinctrl, pinctrl_state);
> ^~~~~~~~~~~~~~~~~~~~
> inc_node_state
> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_iodelay_pinctrl_state':
> drivers/mmc/host/sdhci-omap.c:740:18: error: implicit declaration of function 'pinctrl_lookup_state'; did you mean 'inc_node_state'? [-Werror=implicit-function-declaration]
> pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
> ^~~~~~~~~~~~~~~~~~~~
> inc_node_state
> drivers/mmc/host/sdhci-omap.c:740:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> pinctrl_state = pinctrl_lookup_state(omap_host->pinctrl, mode);
> ^
> drivers/mmc/host/sdhci-omap.c: In function 'sdhci_omap_config_iodelay_pinctrl_state':
> drivers/mmc/host/sdhci-omap.c:769:23: error: implicit declaration of function 'devm_pinctrl_get'; did you mean 'devm_clk_get'? [-Werror=implicit-function-declaration]
> omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
> ^~~~~~~~~~~~~~~~
> devm_clk_get
> drivers/mmc/host/sdhci-omap.c:769:21: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> omap_host->pinctrl = devm_pinctrl_get(omap_host->dev);
> ^
> drivers/mmc/host/sdhci-omap.c:775:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> state = pinctrl_lookup_state(omap_host->pinctrl, "default");
> ^
>
> Caused by commit
>
> 713190bb14aa ("mmc: sdhci_omap: Add support to set IODELAY values")
>
> Forgot to include linux/pinctrl/consumer.h?
yeah, looks like it though I didn't observe this error with omap2plus_defconfig.
Ulf, can you drop "mmc: sdhci_omap: Add support to set IODELAY values" patch
from your next. I'll resend the patch after fixing it.
Thanks
Kishon
next prev parent reply other threads:[~2018-02-15 5:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 0:49 linux-next: build failure after merge of the mmc tree Stephen Rothwell
2018-02-15 5:29 ` Kishon Vijay Abraham I [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-09 1:34 Stephen Rothwell
2023-06-09 6:10 ` Wenbin Mei (梅文彬)
2023-05-10 1:18 Stephen Rothwell
2023-05-10 2:26 ` Jakub Kicinski
2023-05-11 10:54 ` Ulf Hansson
2021-04-16 3:48 Stephen Rothwell
2021-04-16 3:49 ` Stephen Rothwell
2021-04-26 1:31 ` Stephen Rothwell
2021-04-26 9:46 ` Ulf Hansson
2020-10-06 5:29 Stephen Rothwell
2020-09-25 4:40 Stephen Rothwell
2020-06-02 3:44 Stephen Rothwell
2020-06-02 12:05 ` Ulf Hansson
2020-06-02 12:15 ` Kalle Valo
2020-05-18 4:27 Stephen Rothwell
2020-05-18 6:10 ` Martin Blumenstingl
2014-05-30 3:23 Stephen Rothwell
2014-06-02 9:31 ` Ulf Hansson
[not found] ` <20140602214039.10062.15077@quantum>
2014-06-02 21:43 ` Chris Ball
2014-05-26 4:07 Stephen Rothwell
2014-06-02 5:11 ` Stephen Rothwell
2014-06-03 22:52 ` Stephen Rothwell
2014-06-04 19:21 ` Chris Ball
2014-06-05 2:57 ` Chris Ball
2014-05-23 5:32 Stephen Rothwell
2014-05-23 8:45 ` Sebastian Hesselbarth
2014-04-22 3:06 Stephen Rothwell
2014-04-22 4:57 ` Seungwon Jeon
2014-04-22 8:40 ` Ulf Hansson
2014-04-22 11:10 ` Chris Ball
2013-12-13 1:57 Stephen Rothwell
2013-12-17 2:28 ` Stephen Rothwell
2013-12-17 3:07 ` Dong Aisheng
2013-12-17 3:16 ` Shawn Guo
2013-12-17 8:06 ` Dong Aisheng
2014-01-06 6:22 ` Stephen Rothwell
2014-01-06 6:30 ` Dong Aisheng
2014-01-06 6:46 ` Shawn Guo
2014-01-06 6:46 ` Dong Aisheng
2014-01-06 6:30 ` Shawn Guo
2014-01-06 6:44 ` Shawn Guo
2014-01-06 7:29 ` Stephen Rothwell
2014-01-07 3:27 ` Stephen Rothwell
2014-01-13 17:49 ` Chris Ball
2013-12-23 1:40 ` Stephen Rothwell
2011-11-09 1:06 Stephen Rothwell
2011-11-09 1:35 ` Chris Ball
2011-09-22 6:13 Stephen Rothwell
2011-09-22 11:56 ` Chris Ball
2011-07-16 9:30 Stephen Rothwell
2011-07-18 22:29 ` Per Forlin
2011-03-28 2:10 Stephen Rothwell
2010-10-25 1:12 Stephen Rothwell
2010-10-25 2:21 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c278d6eb-8ca2-c25c-3ff9-2d62d758317d@ti.com \
--to=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).