From: Lucas Stach <l.stach@pengutronix.de>
To: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Igor Opanyuk <igor.opanyuk@toradex.com>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: colibri-imx7: fix ethernet performance
Date: Thu, 16 Jan 2020 12:35:40 +0100 [thread overview]
Message-ID: <d3b02f79be206a14d7810c42e08ab9e224f40ae2.camel@pengutronix.de> (raw)
In-Reply-To: <20200116101313.2524795-1-oleksandr.suvorov@toradex.com>
On Do, 2020-01-16 at 10:13 +0000, Oleksandr Suvorov wrote:
> Performance test of ethernet interface shows extremely low result:
>
> === w/o fix =================
> Connecting to host 192.168.x.x, port 5201
> [ 5] local 192.168.x.y port59020 connected to 192.168.x.x port 5201
> ...
> [ ID] Interval Transfer Bitrate Retr
> [ 5] 0.00-10.00 sec 2.78 MBytes 2.33 Mbits/sec 337 sender
> [ 5] 0.00-10.00 sec 2.66 MBytes 2.23
> Mbits/sec receiver
> =============================
>
> Adding correct settings of the mdio bus with the respective phy
> fixes this issue.
So what's the actual issue being fixed here? High packet loss due to
trying to force GBit speeds through 100MBit magnetics? So the addition
of "max-speed = <100>;" is the real core of the fix?
The commit log should mention this.
Regards,
Lucas
>
> === after fix ===============
> iperf3 -c 192.168.x.x
> Connecting to host 192.168.x.x, port 5201
> [ 5] local 192.168.x.y port 50702 connected to 192.168.x.x port 5201
> ...
> [ ID] Interval Transfer Bitrate Retr
> [ 5] 0.00-10.00 sec 114 MBytes 95.4 Mbits/sec 56 sender
> [ 5] 0.00-10.00 sec 112 MBytes 94.1
> Mbits/sec receiver
> =============================
>
> Fixed: commit b326629f25b7 ("ARM: dts: imx7: add Toradex Colibri
> iMX7S/iMX7D support")
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
>
> ---
>
> arch/arm/boot/dts/imx7-colibri.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> b/arch/arm/boot/dts/imx7-colibri.dtsi
> index d05be3f0e2a7..7b6a7c124345 100644
> --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> @@ -115,7 +115,20 @@ &fec1 {
> assigned-clock-rates = <0>, <100000000>;
> phy-mode = "rmii";
> phy-supply = <®_LDO1>;
> + phy-handle = <ðphy0>;
> fsl,magic-packet;
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ethphy0: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + max-speed = <100>;
> + micrel,led-mode = <0>;
> + reg = <0>;
> + };
> + };
> };
>
> &flexcan1 {
next prev parent reply other threads:[~2020-01-16 11:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 10:13 [PATCH] ARM: dts: colibri-imx7: fix ethernet performance Oleksandr Suvorov
2020-01-16 11:35 ` Lucas Stach [this message]
2020-01-17 19:25 ` Oleksandr Suvorov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3b02f79be206a14d7810c42e08ab9e224f40ae2.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=igor.opanyuk@toradex.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mark.rutland@arm.com \
--cc=oleksandr.suvorov@toradex.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).