From: "Robert Milkowski" <rmilkowski@gmail.com>
To: <linux-nfs@vger.kernel.org>
Cc: "'Trond Myklebust'" <trond.myklebust@hammerspace.com>,
"'Anna Schumaker'" <anna.schumaker@netapp.com>,
<linux-kernel@vger.kernel.org>, <linux-nfs@vger.kernel.org>
Subject: RE: [PATCH] NFSv4: nfs4_do_fsinfo() should not do implicit lease renewals
Date: Mon, 16 Dec 2019 18:41:10 -0000 [thread overview]
Message-ID: <05dd01d5b440$63421740$29c645c0$@gmail.com> (raw)
In-Reply-To: <05cd01d5b43f$b7d88f60$2789ae20$@gmail.com>
>btw: Recent ONTAP versions return NFS4ERR_STALE_CLIENTID which is handled
correctly - Linux client will try to renew its lease and if successful it
will retry open().
One more comment here, although the issue won't manifest to applications
with NetApp fileservers in this case, it is still wrong for the client to
end up in such a state.
Also, you will need to wait longer (keep unmounting/mounting) with NetApp
filers as they seem to have implemented courtesy locks/delayed lease
expiration as per the RFC.
This means to reproduce the issue against NetApp you need to wait at least
2x grace period + 1 minute).
Best regards,
Robert Milkowski
prev parent reply other threads:[~2019-12-16 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 17:38 [PATCH] NFSv4: nfs4_do_fsinfo() should not do implicit lease renewals Robert Milkowski
2019-12-16 18:24 ` Trond Myklebust
2019-12-16 18:43 ` Robert Milkowski
2019-12-16 18:58 ` Trond Myklebust
2019-12-17 18:12 ` Robert Milkowski
2019-12-18 14:48 ` Robert Milkowski
2019-12-16 18:58 ` Chuck Lever
2019-12-16 18:36 ` Robert Milkowski
2019-12-16 18:41 ` Robert Milkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='05dd01d5b440$63421740$29c645c0$@gmail.com' \
--to=rmilkowski@gmail.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).