From: Steve Dickson <SteveD@RedHat.com>
To: Patrick Steinhardt <ps@pks.im>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/3] nfsdcld: add missing include for PATH_MAX
Date: Mon, 26 Aug 2019 14:03:35 -0400 [thread overview]
Message-ID: <06e5c667-a5dd-4b37-b31b-8db384e33dbd@RedHat.com> (raw)
In-Reply-To: <15b474e6fa7aee12e64e4376f7716a232e40100a.1566805721.git.ps@pks.im>
On 8/26/19 3:48 AM, Patrick Steinhardt wrote:
> While glibc transitively includes <limits.h> and thus has PATH_MAX
> available, other libc implementations may not have the transitive
> include and thus miss the definition. Add an explicit include of
> <limits.h> to fix compilation with musl libc.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
Committed...
steved.
> ---
> utils/nfsdcld/legacy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/utils/nfsdcld/legacy.c b/utils/nfsdcld/legacy.c
> index f0ca3168..07f477ab 100644
> --- a/utils/nfsdcld/legacy.c
> +++ b/utils/nfsdcld/legacy.c
> @@ -24,6 +24,7 @@
> #include <errno.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> +#include <limits.h>
> #include "cld.h"
> #include "sqlite.h"
> #include "xlog.h"
>
next prev parent reply other threads:[~2019-08-26 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 7:48 [PATCH 1/3] mount: fix compilation if __GLIBC__ is not defined Patrick Steinhardt
2019-08-26 7:48 ` [PATCH 2/3] nfsdcld: add missing include for PATH_MAX Patrick Steinhardt
2019-08-26 18:03 ` Steve Dickson [this message]
2019-08-26 7:48 ` [PATCH 3/3] tests: add missing include for strerror(3P) Patrick Steinhardt
2019-08-26 18:03 ` Steve Dickson
2019-08-26 18:03 ` [PATCH 1/3] mount: fix compilation if __GLIBC__ is not defined Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06e5c667-a5dd-4b37-b31b-8db384e33dbd@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).