From: Manjunath Patil <manjunath.b.patil@oracle.com>
To: linux-nfs@vger.kernel.org
Cc: manjunath.b.patil@oracle.com
Subject: [PATCH 2/2] nfsd: return ENOSPC if unable to allocate a session slot
Date: Thu, 21 Jun 2018 16:35:33 +0000 [thread overview]
Message-ID: <1529598933-16506-2-git-send-email-manjunath.b.patil@oracle.com> (raw)
In-Reply-To: <1529598933-16506-1-git-send-email-manjunath.b.patil@oracle.com>
Presently nfserr_jukebox is being returned by nfsd for create_session
request if server is unable to allocate a session slot. This may be
treated as NFS4ERR_DELAY by the clients and which may continue to re-try
create_session in loop leading NFSv4.1+ mounts in hung state. nfsd
should return nfserr_nospc in this case as per rfc5661(section-18.36.4
subpoint 4. Session creation).
Signed-off-by: Manjunath Patil <manjunath.b.patil@oracle.com>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 8571414..3734e08 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2716,7 +2716,7 @@ static __be32 check_forechannel_attrs(struct nfsd4_channel_attrs *ca, struct nfs
*/
ca->maxreqs = nfsd4_get_drc_mem(ca);
if (!ca->maxreqs)
- return nfserr_jukebox;
+ return nfserr_nospc;
return nfs_ok;
}
--
1.8.3.1
next prev parent reply other threads:[~2018-06-21 16:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 16:35 [PATCH 1/2] nfsv4: handle ENOSPC during create session Manjunath Patil
2018-06-21 16:35 ` Manjunath Patil [this message]
2018-06-22 17:54 ` [PATCH 2/2] nfsd: return ENOSPC if unable to allocate a session slot J. Bruce Fields
2018-06-22 21:49 ` Chuck Lever
2018-06-22 22:31 ` Trond Myklebust
2018-06-22 23:10 ` Trond Myklebust
2018-06-23 19:00 ` Chuck Lever
2018-06-24 13:56 ` Trond Myklebust
2018-06-25 15:39 ` Chuck Lever
2018-06-25 16:45 ` Trond Myklebust
2018-06-25 17:03 ` Manjunath Patil
2018-06-24 20:26 ` J. Bruce Fields
[not found] ` <bde64edc-5684-82d7-4488-e2ebdd7018fc@oracle.com>
2018-06-25 22:04 ` J. Bruce Fields
2018-06-26 17:20 ` Manjunath Patil
2018-07-09 14:25 ` J. Bruce Fields
2018-07-09 21:57 ` Trond Myklebust
2018-06-21 17:04 ` [PATCH 1/2] nfsv4: handle ENOSPC during create session Trond Myklebust
2018-06-22 14:28 ` Manjunath Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529598933-16506-2-git-send-email-manjunath.b.patil@oracle.com \
--to=manjunath.b.patil@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).