linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <mingli.yu@windriver.com>
To: <linux-nfs@vger.kernel.org>
Subject: [PATCH] configure.ac: Do not fatalize -Wmissing-prototypes
Date: Mon, 17 Dec 2018 15:43:13 +0800	[thread overview]
Message-ID: <1545032593-8622-1-git-send-email-mingli.yu@windriver.com> (raw)

From: Mingli Yu <Mingli.Yu@windriver.com>

There comes below error when run "make -C tests/nsm_client nsm_client"
| nlm_sm_inter_svc.c:20:1: error: no previous prototype for 'nlm_sm_prog_3' [-Werror=missing-prototypes]

It is because rpcgen doesn't generate -Wmissing-prototypes
free code for nlm_sm_inter_svc.c with below logic
in tests/nsm_client/Makefile.am
[snip]
GENFILES_SVC    = nlm_sm_inter_svc.c
[snip]
$(GENFILES_SVC): %_svc.c: %.x $(RPCGEN)
        test -f $@ && rm -rf $@ || true
        $(RPCGEN) -m -o $@ $<

Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 4bf5aea..af86e4e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -552,7 +552,7 @@ my_am_cflags="\
  -Wall \
  -Wextra \
  $rpcgen_cflags \
- -Werror=missing-prototypes \
+ -Wmissing-prototypes \
  -Werror=missing-declarations \
  -Werror=format=2 \
  -Werror=undef \
-- 
2.7.4


                 reply	other threads:[~2018-12-17  7:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1545032593-8622-1-git-send-email-mingli.yu@windriver.com \
    --to=mingli.yu@windriver.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).