From: Chuck Lever <chuck.lever@oracle.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Bruce Fields <bfields@fieldses.org>,
Jeff Layton <jlayton@poochiereds.net>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Improvements to nfsd stats
Date: Thu, 21 Jan 2021 23:39:20 +0000 [thread overview]
Message-ID: <1FD02545-2449-4CA5-B408-957495138CE6@oracle.com> (raw)
In-Reply-To: <20210106075236.4184-1-amir73il@gmail.com>
Hello Amir!
> On Jan 6, 2021, at 2:52 AM, Amir Goldstein <amir73il@gmail.com> wrote:
>
> Hi Bruce,
>
> Per your request, I added a cleanup patch for unused counter.
>
> Replaced the hacky counters array "union" with proper array
> and added helpers to update the counters to avoid human mistakes
> related to counter indices.
Thanks for your patches. v2 of your series has been committed
to the for-next branch at
git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
in preparation for the v5.12 merge window.
> Thanks,
> Amir.
>
> Changes since v1:
> - Cleanup unused stats counters (Bruce)
> - Replace counters array hack with proper array (Chuck)
> - Helpers to update both global and per-export stats
>
> Amir Goldstein (3):
> nfsd: remove unused stats counters
> nfsd: protect concurrent access to nfsd stats counters
> nfsd: report per-export stats
>
> fs/nfsd/export.c | 68 +++++++++++++++++++++++----
> fs/nfsd/export.h | 15 ++++++
> fs/nfsd/netns.h | 23 +++++----
> fs/nfsd/nfs4proc.c | 2 +-
> fs/nfsd/nfscache.c | 52 +++++++++++++++------
> fs/nfsd/nfsctl.c | 8 +++-
> fs/nfsd/nfsd.h | 2 +-
> fs/nfsd/nfsfh.c | 4 +-
> fs/nfsd/stats.c | 114 +++++++++++++++++++++++++++++++--------------
> fs/nfsd/stats.h | 96 +++++++++++++++++++++++++++++---------
> fs/nfsd/vfs.c | 4 +-
> 11 files changed, 292 insertions(+), 96 deletions(-)
>
> --
> 2.17.1
>
--
Chuck Lever
next prev parent reply other threads:[~2021-01-21 23:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 7:52 [PATCH v2 0/3] Improvements to nfsd stats Amir Goldstein
2021-01-06 7:52 ` [PATCH v2 1/3] nfsd: remove unused stats counters Amir Goldstein
2021-01-06 7:52 ` [PATCH v2 2/3] nfsd: protect concurrent access to nfsd " Amir Goldstein
2021-01-06 20:50 ` J . Bruce Fields
2021-01-07 7:17 ` Amir Goldstein
2021-01-07 14:25 ` J . Bruce Fields
2021-01-06 7:52 ` [PATCH v2 3/3] nfsd: report per-export stats Amir Goldstein
2021-01-21 23:39 ` Chuck Lever [this message]
2021-01-22 6:54 ` [PATCH v2 0/3] Improvements to nfsd stats Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1FD02545-2449-4CA5-B408-957495138CE6@oracle.com \
--to=chuck.lever@oracle.com \
--cc=amir73il@gmail.com \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).