From: "J. Bruce Fields" <bfields@fieldses.org>
To: Mi Jinlong <mijinlong@cn.fujitsu.com>
Cc: NFS <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2 v4] nfsd41: check the size of request
Date: Thu, 14 Jul 2011 10:51:08 -0400 [thread overview]
Message-ID: <20110714145108.GD13000@fieldses.org> (raw)
In-Reply-To: <4E1E9302.4080504@cn.fujitsu.com>
On Thu, Jul 14, 2011 at 02:56:02PM +0800, Mi Jinlong wrote:
> This patch checks request's size when it consists SEQUENCE.
>
> v4:
> delete format fixing which length exceed 80
>
> v3:
> remove the check about only SEQUENCE operation.
> check the size immediately after find session.
> modify some function's format which length exceed 80.
Both applied, thanks!
--b.
>
> Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
> ---
> fs/nfsd/nfs4state.c | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 72899ec..cc20587 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1763,6 +1763,14 @@ static bool nfsd4_session_too_many_ops(struct svc_rqst *rqstp, struct nfsd4_sess
> return args->opcnt > session->se_fchannel.maxops;
> }
>
> +static bool nfsd4_request_too_big(struct svc_rqst *rqstp,
> + struct nfsd4_session *session)
> +{
> + struct xdr_buf *xb = &rqstp->rq_arg;
> +
> + return xb->len > session->se_fchannel.maxreq_sz;
> +}
> +
> __be32
> nfsd4_sequence(struct svc_rqst *rqstp,
> struct nfsd4_compound_state *cstate,
> @@ -1795,6 +1803,10 @@ nfsd4_sequence(struct svc_rqst *rqstp,
> if (nfsd4_session_too_many_ops(rqstp, session))
> goto out;
>
> + status = nfserr_req_too_big;
> + if (nfsd4_request_too_big(rqstp, session))
> + goto out;
> +
> status = nfserr_badslot;
> if (seq->slotid >= session->se_fchannel.maxreqs)
> goto out;
> --
> 1.7.5.4
>
>
>
prev parent reply other threads:[~2011-07-14 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-02 9:02 [PATCH 2/2 v2] nfsd41: check the size of request Mi Jinlong
2011-07-06 16:43 ` J. Bruce Fields
2011-07-08 9:13 ` Mi Jinlong
2011-07-08 20:03 ` J. Bruce Fields
2011-07-09 2:19 ` [PATCH 2/2 v3] " Mi Jinlong
2011-07-13 0:25 ` J. Bruce Fields
2011-07-14 6:56 ` [PATCH 2/2 v4] " Mi Jinlong
2011-07-14 14:51 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714145108.GD13000@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=mijinlong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).