From: "bfields@fieldses.org" <bfields@fieldses.org>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "schumakeranna@gmail.com" <schumakeranna@gmail.com>,
"chucklever@gmail.com" <chucklever@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: NULL dereference in rpcauth_lookup_credcache
Date: Mon, 12 Nov 2018 18:01:49 -0500 [thread overview]
Message-ID: <20181112230149.GF16755@fieldses.org> (raw)
In-Reply-To: <2e62a77385b4e5d91e2ca9128313cf817c46a1ae.camel@hammerspace.com>
On Mon, Nov 12, 2018 at 09:17:16PM +0000, Trond Myklebust wrote:
> On Mon, 2018-11-12 at 13:24 -0500, bfields@fieldses.org wrote:
> > On Mon, Nov 12, 2018 at 05:59:33PM +0000, Trond Myklebust wrote:
> > > On Sat, 2018-11-10 at 16:49 -0500, Bruce Fields wrote:
> > > > Looks like it's the fault of
> > > >
> > > > 07d02a67b7faae "SUNRPC: Simplify lookup code"
> > >
> > > I'm having trouble reproducing this bug. I've tried both cthon and
> > > xfstests in a loop, so far without success (both NFSv3 and v4.1,
> > > but
> > > only sec=sys). Is there anything else you're doing that I might
> > > try?
> > >
> > > e.g. Are you running multiple workloads in parallel? Different
> > > users?..
> >
> > Nothing that interesting. Currently it's connectathon over v4, v3,
> > v4/krb5, v3/krb5, v4/krb5i, v4/krb5p, v4.1, v4.1/krb5, but just
> > serially
> > one after the other. Then some pynfs tests (which bypass the
> > client),
> > then xfstests over v4.2/sys. And also a few one-off locking tests of
> > my
> > own that probably aren't a factor here.
> >
> > (Hah, I just realized I was mounting with vers=4 and assuming that
> > meant
> > 4.0, but actually it's changed over time depending on the defaults,
> > so
> > currently those "v4" runs are actually all 4.2. Gah.)
>
> Are you perhaps both using RPCSEC_GSS w/ integrity checking for your
> EXCHANGE_ID authentication? The client will attempt to use that by
> default if rpc.gssd is running.
Yes, in addition to the krb5i mount I'd expect the sys/krb5/krb5p mounts
are using krb5i for EXCHANGE_ID.
> I ask because I think the issue might be with RPCSEC_GSS, specifically
> with the RPCSEC_GSS context destroy code, hence the 2 patches that I
> just sent out.
Looks like my tests pass after applying those two patches.
--b.
next prev parent reply other threads:[~2018-11-12 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 21:44 NULL dereference in rpcauth_lookup_credcache J. Bruce Fields
2018-11-09 18:01 ` Chuck Lever
2018-11-10 21:49 ` Bruce Fields
2018-11-12 17:59 ` Trond Myklebust
2018-11-12 18:16 ` Chuck Lever
2018-11-12 18:18 ` Trond Myklebust
2018-11-12 18:24 ` bfields
2018-11-12 21:17 ` Trond Myklebust
2018-11-12 23:01 ` bfields [this message]
2018-11-12 23:57 ` Trond Myklebust
2018-11-13 0:00 ` Chuck Lever
2018-11-13 0:08 ` Trond Myklebust
2018-11-13 0:17 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112230149.GF16755@fieldses.org \
--to=bfields@fieldses.org \
--cc=chucklever@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=schumakeranna@gmail.com \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).