From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8888C04EB9 for ; Wed, 5 Dec 2018 14:12:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7BE962082B for ; Wed, 5 Dec 2018 14:12:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="UC5Apv4m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BE962082B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727177AbeLEOMy (ORCPT ); Wed, 5 Dec 2018 09:12:54 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:60188 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727135AbeLEOMy (ORCPT ); Wed, 5 Dec 2018 09:12:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=nxSK4dE9PuUkQMI68/42sjodkJ2Ca+erf1/lre3zGD0=; b=UC5Apv4mA4yeb25T1qxH8YeDg Vix33zH5E2SY4s7PmJ57wbpJMkBXTknbqORXNfoNTJYrgNes4hWbCNKL8Cpr7wKkA7+NFtvpzjFfe O6TxWe06mmI26704K2xS4YmrhAdjBiduC9G9lB+kjpapPa+uhyIT6g9AxfdaR81GPp5LTfsPhAn4o DrX4gbkxeiXkiLU0IaGhrKJJF5OsXJc3/TICyeA/No6Gnvy34QmmTht5bn0SDEjzkO2DE74uZkmoG 58EiZ8R8+l5yldUHdknC4mKFsO8R3Oolqr5Wvrn/AP2XI7paBxEUROcO+SUAZGDcwveNlmlWD9ysN Lah2QCHBQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gUXv3-0008KR-2X; Wed, 05 Dec 2018 14:12:53 +0000 Date: Wed, 5 Dec 2018 06:12:52 -0800 From: Christoph Hellwig To: Dave Chinner Cc: Christoph Hellwig , Amir Goldstein , linux-fsdevel , linux-xfs , Olga Kornievskaia , Linux NFS Mailing List , overlayfs , ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org Subject: Re: [PATCH 01/11] vfs: copy_file_range source range over EOF should fail Message-ID: <20181205141252.GB21109@infradead.org> References: <20181203083416.28978-1-david@fromorbit.com> <20181203083416.28978-2-david@fromorbit.com> <20181204151332.GA32245@infradead.org> <20181204212948.GO6311@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181204212948.GO6311@dastard> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > Realistically, though, I think an attempt to read beyond EOF for the > copy should result in behaviour like read() (i.e. return 0 bytes), > not EINVAL. The existing behaviour needs to change, though. I agree with this statement. So we don't we implement these semantics?