From: Scott Mayhew <smayhew@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: jlayton@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 3/3] nfsd: keep a tally of RECLAIM_COMPLETE operations when using nfsdcld
Date: Wed, 19 Dec 2018 17:01:18 -0500 [thread overview]
Message-ID: <20181219220118.GR27213@coeurl.usersys.redhat.com> (raw)
In-Reply-To: <20181219182831.GB28626@fieldses.org>
On Wed, 19 Dec 2018, J. Bruce Fields wrote:
> On Tue, Dec 18, 2018 at 09:29:26AM -0500, Scott Mayhew wrote:
> > diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> > index 89c2a27956d0..ae74814b2397 100644
> > --- a/fs/nfsd/nfs4recover.c
> > +++ b/fs/nfsd/nfs4recover.c
> > @@ -1251,6 +1251,7 @@ nfsd4_cld_grace_done(struct nfsd_net *nn)
> > free_cld_upcall(cup);
> > out_err:
> > nfs4_release_reclaim(nn);
> > + atomic_set(&nn->nr_reclaim_complete, 0);
> > if (ret)
> > printk(KERN_ERR "NFSD: Unable to end grace period: %d\n", ret);
> > }
> > @@ -1270,6 +1271,8 @@ nfs4_cld_state_init(struct net *net)
> > for (i = 0; i < CLIENT_HASH_SIZE; i++)
> > INIT_LIST_HEAD(&nn->reclaim_str_hashtbl[i]);
> > nn->reclaim_str_hashtbl_size = 0;
> > + nn->track_reclaim_completes = true;
> > + atomic_set(&nn->nr_reclaim_complete, 0);
> >
> > return 0;
> > }
> ...
> > @@ -1318,6 +1322,7 @@ nfsd4_cld_tracking_exit(struct net *net)
> > struct nfsd_net *nn = net_generic(net, nfsd_net_id);
> >
> > nfs4_release_reclaim(nn);
> > + atomic_set(&nn->nr_reclaim_complete, 0);
> > nfsd4_remove_cld_pipe(net);
> > nfs4_cld_state_shutdown(net);
> > }
>
> We're initializing nr_reclaim_complete in 3 different places, probably
> only one of those is really necessary?
Yes, only the one in nfs4_cld_state_init() is really necessary. If the
ability to put a running server into grace is ever added, then I think
the counter would need to be reset there too.
-Scott
>
> --b.
next prev parent reply other threads:[~2018-12-19 22:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 14:29 [PATCH v2 0/3] un-deprecate nfsdcld Scott Mayhew
2018-12-18 14:29 ` [PATCH v2 1/3] nfsd: make nfs4_client_reclaim use an xdr_netobj instead of a fixed char array Scott Mayhew
2018-12-18 14:29 ` [PATCH v2 2/3] nfsd: un-deprecate nfsdcld Scott Mayhew
2018-12-19 21:23 ` Jeff Layton
2018-12-19 22:11 ` Scott Mayhew
2018-12-20 0:19 ` Jeff Layton
2018-12-20 1:59 ` J. Bruce Fields
2018-12-20 15:24 ` Jeff Layton
2018-12-18 14:29 ` [PATCH v2 3/3] nfsd: keep a tally of RECLAIM_COMPLETE operations when using nfsdcld Scott Mayhew
2018-12-19 17:46 ` J. Bruce Fields
2018-12-19 21:57 ` Scott Mayhew
2018-12-19 18:28 ` J. Bruce Fields
2018-12-19 22:01 ` Scott Mayhew [this message]
2018-12-19 18:36 ` J. Bruce Fields
2018-12-19 22:05 ` Scott Mayhew
2018-12-19 22:21 ` J. Bruce Fields
2018-12-19 22:43 ` J. Bruce Fields
2018-12-20 16:36 ` Scott Mayhew
2018-12-20 17:32 ` Jeff Layton
2018-12-20 17:29 ` Jeff Layton
2018-12-20 18:05 ` J. Bruce Fields
2018-12-20 18:26 ` Jeff Layton
2018-12-20 19:02 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219220118.GR27213@coeurl.usersys.redhat.com \
--to=smayhew@redhat.com \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).