From: "J. Bruce Fields" <bfields@fieldses.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/20] nfsd: drop useless LIST_HEAD
Date: Sun, 23 Dec 2018 16:26:10 -0500 [thread overview]
Message-ID: <20181223212610.GB3183@fieldses.org> (raw)
In-Reply-To: <1545555435-24576-2-git-send-email-Julia.Lawall@lip6.fr>
Applied, thanks.--b.
On Sun, Dec 23, 2018 at 09:56:56AM +0100, Julia Lawall wrote:
> Drop LIST_HEAD where the variable it declares is never used.
>
> This was introduced in c5c707f96fc9a ("nfsd: implement pNFS
> layout recalls"), but was not used even in that commit.
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> identifier x;
> @@
> - LIST_HEAD(x);
> ... when != x
> // </smpl>
>
> Fixes: c5c707f96fc9a ("nfsd: implement pNFS layout recalls")
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Successfully 0-day tested on 151 configurations.
>
> fs/nfsd/nfs4layouts.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4layouts.c b/fs/nfsd/nfs4layouts.c
> index 2b36aa037ce0..44517fb5c0de 100644
> --- a/fs/nfsd/nfs4layouts.c
> +++ b/fs/nfsd/nfs4layouts.c
> @@ -656,7 +656,6 @@ nfsd4_cb_layout_done(struct nfsd4_callback *cb, struct rpc_task *task)
> struct nfsd_net *nn;
> ktime_t now, cutoff;
> const struct nfsd4_layout_ops *ops;
> - LIST_HEAD(reaplist);
>
>
> switch (task->tk_status) {
next prev parent reply other threads:[~2018-12-23 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-23 8:56 [PATCH 00/20] drop useless LIST_HEAD Julia Lawall
2018-12-23 8:56 ` [PATCH 01/20] nfsd: " Julia Lawall
2018-12-23 21:26 ` J. Bruce Fields [this message]
2018-12-23 8:57 ` [PATCH 15/20] NFS: " Julia Lawall
2019-02-21 22:40 ` Trond Myklebust
2018-12-23 21:49 ` [PATCH 00/20] " Tom Psyborg
2018-12-23 22:06 ` Julia Lawall
2018-12-25 22:12 ` Tom Psyborg
2018-12-27 13:40 ` Dan Carpenter
2018-12-29 5:25 ` Darrick J. Wong
2018-12-29 6:19 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181223212610.GB3183@fieldses.org \
--to=bfields@fieldses.org \
--cc=Julia.Lawall@lip6.fr \
--cc=jlayton@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).