linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Trond Myklebust <trondmy@gmail.com>
Cc: kbuild-all@01.org, Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Fix TCP receive code on archs with flush_dcache_page()
Date: Thu, 3 Jan 2019 13:29:07 +0800	[thread overview]
Message-ID: <201901031301.BvA4LE3B%fengguang.wu@intel.com> (raw)
In-Reply-To: <20190103004211.12404-1-trond.myklebust@hammerspace.com>

[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]

Hi Trond,

I love your patch! Yet something to improve:

[auto build test ERROR on nfs/linux-next]
[also build test ERROR on v4.20 next-20190102]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Trond-Myklebust/SUNRPC-Fix-TCP-receive-code-on-archs-with-flush_dcache_page/20190103-113507
base:   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git linux-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sh 

All errors (new ones prefixed by >>):

   net//sunrpc/xprtsock.c: In function 'xs_flush_bvec':
>> net//sunrpc/xprtsock.c:396:24: error: 'struct bio_vec' has no member named 'page'; did you mean 'bv_page'?
      flush_dcache_page(bv.page);
                           ^~~~
                           bv_page

vim +396 net//sunrpc/xprtsock.c

   383	
   384	#if ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE
   385	static void
   386	xs_flush_bvec(const struct bio_vec *bvec, size_t count, size_t seek)
   387	{
   388		struct bvec_iter bi, __start = {
   389			.bi_size = count,
   390		};
   391		struct bio_vec bv;
   392	
   393		bvec_iter_advance(bvec, &__start, seek & PAGE_MASK);
   394	
   395		for_each_bvec(bv, bvec, bi, __start)
 > 396			flush_dcache_page(bv.page);
   397	}
   398	#else
   399	static inline void
   400	xs_flush_bvec(const struct bio_vec *bvec, size_t count, size_t seek)
   401	{
   402	}
   403	#endif
   404	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50781 bytes --]

  reply	other threads:[~2019-01-03  5:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03  0:42 [PATCH] SUNRPC: Fix TCP receive code on archs with flush_dcache_page() Trond Myklebust
2019-01-03  5:29 ` kbuild test robot [this message]
2019-01-03  6:45 ` kbuild test robot
2019-01-03 13:52 ` Sasha Levin
2019-01-03 14:00   ` Geert Uytterhoeven
2019-01-05 20:53     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201901031301.BvA4LE3B%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=geert@linux-m68k.org \
    --cc=kbuild-all@01.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).