linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v2 11/21] xprtrdma: Trace marshaling failures
Date: Tue, 16 Apr 2019 09:37:49 -0400	[thread overview]
Message-ID: <20190416133749.23113.10719.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20190416133156.23113.91846.stgit@manet.1015granger.net>

Record an event when rpcrdma_marshal_req returns a non-zero return
value to help track down why an xprt close might have occurred.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 include/trace/events/rpcrdma.h |   27 +++++++++++++++++++++++++++
 net/sunrpc/xprtrdma/rpc_rdma.c |    1 +
 2 files changed, 28 insertions(+)

diff --git a/include/trace/events/rpcrdma.h b/include/trace/events/rpcrdma.h
index 962975b..df9851cb 100644
--- a/include/trace/events/rpcrdma.h
+++ b/include/trace/events/rpcrdma.h
@@ -511,6 +511,33 @@
 	)
 );
 
+TRACE_EVENT(xprtrdma_marshal_failed,
+	TP_PROTO(const struct rpc_rqst *rqst,
+		 int ret
+	),
+
+	TP_ARGS(rqst, ret),
+
+	TP_STRUCT__entry(
+		__field(unsigned int, task_id)
+		__field(unsigned int, client_id)
+		__field(u32, xid)
+		__field(int, ret)
+	),
+
+	TP_fast_assign(
+		__entry->task_id = rqst->rq_task->tk_pid;
+		__entry->client_id = rqst->rq_task->tk_client->cl_clid;
+		__entry->xid = be32_to_cpu(rqst->rq_xid);
+		__entry->ret = ret;
+	),
+
+	TP_printk("task:%u@%u xid=0x%08x: ret=%d",
+		__entry->task_id, __entry->client_id, __entry->xid,
+		__entry->ret
+	)
+);
+
 TRACE_EVENT(xprtrdma_post_send,
 	TP_PROTO(
 		const struct rpcrdma_req *req,
diff --git a/net/sunrpc/xprtrdma/rpc_rdma.c b/net/sunrpc/xprtrdma/rpc_rdma.c
index 231a44b..45cba06 100644
--- a/net/sunrpc/xprtrdma/rpc_rdma.c
+++ b/net/sunrpc/xprtrdma/rpc_rdma.c
@@ -875,6 +875,7 @@ static bool rpcrdma_prepare_msg_sges(struct rpcrdma_xprt *r_xprt,
 	return 0;
 
 out_err:
+	trace_xprtrdma_marshal_failed(rqst, ret);
 	switch (ret) {
 	case -EAGAIN:
 		xprt_wait_for_buffer_space(rqst->rq_xprt);


  parent reply	other threads:[~2019-04-16 13:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16 13:36 [PATCH v2 00/21] Proposed NFS/RDMA patches for v5.2 Chuck Lever
2019-04-16 13:36 ` [PATCH v2 01/21] SUNRPC: Avoid digging into the ATOMIC pool Chuck Lever
2019-04-16 13:37 ` [PATCH v2 02/21] xprtrdma: Fix an frwr_map recovery nit Chuck Lever
2019-04-16 13:37 ` [PATCH v2 03/21] xprtrdma: Clean up rpcrdma_create_req() Chuck Lever
2019-04-16 13:37 ` [PATCH v2 04/21] xprtrdma: Clean up rpcrdma_create_rep() and rpcrdma_destroy_rep() Chuck Lever
2019-04-16 13:37 ` [PATCH v2 05/21] xprtrdma: rpcrdma_regbuf alignment Chuck Lever
2019-04-16 13:37 ` [PATCH v2 06/21] xprtrdma: Allocate req's regbufs at xprt create time Chuck Lever
2019-04-16 13:37 ` [PATCH v2 07/21] xprtrdma: De-duplicate "allocate new, free old regbuf" Chuck Lever
2019-04-16 13:37 ` [PATCH v2 08/21] xprtrdma: Clean up regbuf helpers Chuck Lever
2019-04-16 13:37 ` [PATCH v2 09/21] xprtrdma: Backchannel can use GFP_KERNEL allocations Chuck Lever
2019-04-16 13:37 ` [PATCH v2 10/21] xprtrdma: Increase maximum number of backchannel request Chuck Lever
2019-04-16 13:37 ` Chuck Lever [this message]
2019-04-16 13:37 ` [PATCH v2 12/21] xprtrdma: Clean up sendctx functions Chuck Lever
2019-04-16 13:38 ` [PATCH v2 13/21] xprtrdma: More Send completion batching Chuck Lever
2019-04-16 13:38 ` [PATCH v2 14/21] xprtrdma: Eliminate rpcrdma_ia::ri_device Chuck Lever
2019-04-16 13:38 ` [PATCH v2 15/21] SUNRPC: Update comments based on recent changes Chuck Lever
2019-04-16 13:38 ` [PATCH v2 16/21] xprtrdma: Remove rpcrdma_create_data_internal::rsize and wsize Chuck Lever
2019-04-16 13:38 ` [PATCH v2 17/21] xprtrdma: Aggregate the inline settings in struct rpcrdma_ep Chuck Lever
2019-04-16 13:38 ` [PATCH v2 18/21] xprtrdma: Eliminate struct rpcrdma_create_data_internal Chuck Lever
2019-04-16 13:38 ` [PATCH v2 19/21] xprtrdma: Remove pr_err() call sites from completion handlers Chuck Lever
2019-04-16 13:38 ` [PATCH v2 20/21] xprtrdma: Update comments that reference ib_drain_qp Chuck Lever
2019-04-16 13:38 ` [PATCH v2 21/21] xprtrdma: Remove stale comment Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190416133749.23113.10719.stgit@manet.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).