Re: [PATCH] nfsd: Ensure CLONE persists data and metadata changes to the target file

From: kbuild test robot <lkp@intel.com>
To: Trond Myklebust <trondmy@gmail.com>
Cc: kbuild-all@lists.01.org, "J. Bruce Fields" <bfields@redhat.com>,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: Ensure CLONE persists data and metadata changes to the target file
Date: Fri, 29 Nov 2019 01:53:13 +0800	[thread overview]
Message-ID: <201911290023.E0Ae2YFx%lkp@intel.com> (raw)
In-Reply-To: <20191127220551.36159-1-trond.myklebust@hammerspace.com>

[-- Attachment #1: Type: text/plain, Size: 2305 bytes --]

Hi Trond,

I love your patch! Yet something to improve:

[auto build test ERROR on nfsd/nfsd-next]
[also build test ERROR on v5.4 next-20191128]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Trond-Myklebust/nfsd-Ensure-CLONE-persists-data-and-metadata-changes-to-the-target-file/20191128-061009
base:   git://linux-nfs.org/~bfields/linux.git nfsd-next
config: parisc-defconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs//nfsd/vfs.c: In function 'nfsd4_clone_file_range':
>> fs//nfsd/vfs.c:540:5: error: 'commit_is_datasync' undeclared (first use in this function); did you mean 'commit_metadata'?
        commit_is_datasync);
        ^~~~~~~~~~~~~~~~~~
        commit_metadata
   fs//nfsd/vfs.c:540:5: note: each undeclared identifier is reported only once for each function it appears in

vim +540 fs//nfsd/vfs.c

   526	
   527	__be32 nfsd4_clone_file_range(struct file *src, u64 src_pos, struct file *dst,
   528			u64 dst_pos, u64 count, bool sync)
   529	{
   530		loff_t cloned;
   531	
   532		cloned = vfs_clone_file_range(src, src_pos, dst, dst_pos, count, 0);
   533		if (cloned < 0)
   534			return nfserrno(cloned);
   535		if (count && cloned != count)
   536			return nfserrno(-EINVAL);
   537		if (sync) {
   538			loff_t dst_end = count ? dst_pos + count - 1 : LLONG_MAX;
   539			int status = vfs_fsync_range(dst, dst_pos, dst_end,
 > 540					commit_is_datasync);
   541			if (status < 0)
   542				return nfserrno(status);
   543		}
   544		return 0;
   545	}
   546	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 16278 bytes --]