From: "J. Bruce Fields" <bfields@fieldses.org>
To: Aditya Pakki <pakki001@umn.edu>
Cc: kjlu@umn.edu, Chuck Lever <chuck.lever@oracle.com>,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: remove unnecessary assertion in nfsd4_encode_replay
Date: Thu, 19 Dec 2019 17:46:22 -0500 [thread overview]
Message-ID: <20191219224622.GF12026@fieldses.org> (raw)
In-Reply-To: <20191217225048.3411-1-pakki001@umn.edu>
Thanks, applying.--b.
On Tue, Dec 17, 2019 at 04:50:47PM -0600, Aditya Pakki wrote:
> The replay variable is set in the only caller of nfsd4_encode_replay.
> The assertion is unnecessary and the patch removes this check.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> fs/nfsd/nfs4xdr.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index d2dc4c0e22e8..fb2433676376 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -4500,8 +4500,6 @@ nfsd4_encode_replay(struct xdr_stream *xdr, struct nfsd4_op *op)
> __be32 *p;
> struct nfs4_replay *rp = op->replay;
>
> - BUG_ON(!rp);
> -
> p = xdr_reserve_space(xdr, 8 + rp->rp_buflen);
> if (!p) {
> WARN_ON_ONCE(1);
> --
> 2.20.1
prev parent reply other threads:[~2019-12-19 22:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 22:50 [PATCH] nfsd: remove unnecessary assertion in nfsd4_encode_replay Aditya Pakki
2019-12-19 22:46 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219224622.GF12026@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).