From: YueHaibing <yuehaibing@huawei.com>
To: Trond Myklebust <trond.myklebust@hammerspace.com>,
Benjamin Coddington <bcodding@redhat.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Cc: YueHaibing <yuehaibing@huawei.com>, <linux-nfs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] NFS: use correct 'verifier' in nfs_lookup_revalidate_dentry
Date: Mon, 3 Feb 2020 15:58:45 +0000 [thread overview]
Message-ID: <20200203155845.50239-1-yuehaibing@huawei.com> (raw)
'verifier' is already set but not used in nfs_set_verifier().
Fixes: 1346d280eafa ("NFS: Revalidate once when holding a delegation")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
fs/nfs/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index 289052c0ae93..882ea5337627 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -1180,7 +1180,7 @@ nfs_lookup_revalidate_dentry(struct inode *dir, struct dentry *dentry,
verifier = nfs_save_change_attribute(dir);
nfs_setsecurity(inode, fattr, label);
- nfs_set_verifier(dentry, nfs_save_change_attribute(dir));
+ nfs_set_verifier(dentry, verifier);
/* set a readdirplus hint that we had a cache miss */
nfs_force_use_readdirplus(dir);
reply other threads:[~2020-02-03 16:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203155845.50239-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=anna.schumaker@netapp.com \
--cc=bcodding@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).