From: "J. Bruce Fields" <bfields@fieldses.org>
To: Frank van der Linden <fllinden@amazon.com>
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v3 00/10] server side user xattr support (RFC 8276)
Date: Thu, 25 Jun 2020 12:53:47 -0400 [thread overview]
Message-ID: <20200625165347.GB30655@fieldses.org> (raw)
In-Reply-To: <20200623223927.31795-1-fllinden@amazon.com>
By the way, I can't remember if I asked this before: is there a
particular use case that motivates this xattr work?
--b.
On Tue, Jun 23, 2020 at 10:39:17PM +0000, Frank van der Linden wrote:
> v3:
> * Rebase to v5.8-rc2
> * Use length probe + allocate + query for the listxattr and setxattr
> operations to avoid allocating unneeded space.
> * Because of the above, drop the 'use kvmalloc for svcxdr_tmpalloc' patch,
> as it's no longer needed.
>
> v2:
> * As per the discussion, user extended attributes are enabled if
> the client and server support them (e.g. they support 4.2 and
> advertise the user extended attribute FATTR). There are no longer
> options to switch them off.
> * The code is no longer conditioned on a config option.
> * The number of patches has been reduced somewhat by merging
> smaller, related ones.
> * Renamed some functions and added parameter comments as requested.
>
> v1:
>
> * Split in to client and server (changed from the original RFC patch).
>
> Original RFC combined set is here:
>
> https://www.spinics.net/lists/linux-nfs/msg74843.html
>
> In general, these patches were, both server and client, tested as
> follows:
> * stress-ng-xattr with 1000 workers
> * Test all corner cases (XATTR_SIZE_*)
> * Test all failure cases (no xattr, setxattr with different or
> invalid flags, etc).
> * Verify the content of xattrs across several operations.
> * Use KASAN and KMEMLEAK for a longer mix of testruns to verify
> that there were no leaks (after unmounting the filesystem).
> * Interop run against FreeBSD server/client implementation.
> * Ran xfstests-dev, with no unexpected/new failures as compared
> to an unpatched kernel. To fully use xfstests-dev, it needed
> some modifications, as it expects to either use all xattr
> namespaces, or none. Whereas NFS only suppors the "user."
> namespace (+ optional ACLs). I will send the changes in
> seperately.
>
>
> Frank van der Linden (10):
> xattr: break delegations in {set,remove}xattr
> xattr: add a function to check if a namespace is supported
> nfs,nfsd: NFSv4.2 extended attribute protocol definitions
> nfsd: split off the write decode code in to a separate function
> nfsd: add defines for NFSv4.2 extended attribute support
> nfsd: define xattr functions to call in to their vfs counterparts
> nfsd: take xattr bits in to account for permission checks
> nfsd: add structure definitions for xattr requests / responses
> nfsd: implement the xattr functions and en/decode logic
> nfsd: add fattr support for user extended attributes
>
> fs/nfsd/nfs4proc.c | 128 ++++++++-
> fs/nfsd/nfs4xdr.c | 531 +++++++++++++++++++++++++++++++++++---
> fs/nfsd/nfsd.h | 5 +-
> fs/nfsd/vfs.c | 239 +++++++++++++++++
> fs/nfsd/vfs.h | 10 +
> fs/nfsd/xdr4.h | 31 +++
> fs/xattr.c | 111 +++++++-
> include/linux/nfs4.h | 22 +-
> include/linux/xattr.h | 4 +
> include/uapi/linux/nfs4.h | 3 +
> 10 files changed, 1044 insertions(+), 40 deletions(-)
>
> --
> 2.17.2
next prev parent reply other threads:[~2020-06-25 16:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 22:39 [PATCH v3 00/10] server side user xattr support (RFC 8276) Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 01/10] xattr: break delegations in {set,remove}xattr Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 02/10] xattr: add a function to check if a namespace is supported Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 03/10] nfs,nfsd: NFSv4.2 extended attribute protocol definitions Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 04/10] nfsd: split off the write decode code in to a separate function Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 05/10] nfsd: add defines for NFSv4.2 extended attribute support Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 06/10] nfsd: define xattr functions to call in to their vfs counterparts Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 07/10] nfsd: take xattr bits in to account for permission checks Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 08/10] nfsd: add structure definitions for xattr requests / responses Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 09/10] nfsd: implement the xattr functions and en/decode logic Frank van der Linden
2020-06-23 22:39 ` [PATCH v3 10/10] nfsd: add fattr support for user extended attributes Frank van der Linden
2020-06-25 16:50 ` [PATCH v3 00/10] server side user xattr support (RFC 8276) J. Bruce Fields
2020-06-25 17:13 ` Frank van der Linden
2020-06-25 16:53 ` J. Bruce Fields [this message]
2020-06-25 17:39 ` Frank van der Linden
2020-06-25 20:07 ` J. Bruce Fields
2020-07-04 14:37 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625165347.GB30655@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=fllinden@amazon.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).