From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: Steve Dickson <SteveD@RedHat.com>, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH 0/7] silence some warning in rpcgen
Date: Thu, 9 Jan 2020 15:00:47 +0100 [thread overview]
Message-ID: <38aa6cba-91e4-f1ec-7978-45ba4b4cf4ee@benettiengineering.com> (raw)
In-Reply-To: <11af1233-d6e1-3952-475d-306dc5fefc06@RedHat.com>
On 1/7/20 8:06 PM, Steve Dickson wrote:
>
>
> On 1/3/20 4:50 PM, Giulio Benetti wrote:
>> Since I'm trying to bump version of nfs-utils to latest in Buildroot, I've
>> noticed some warning in rpcgen, so I've decided to clean them up by fixing
>> code or #pragma ignoring them. Hope this is useful. Other warnings are
>> still there waiting to be fixed and if you find these patches useful I'm
>> going to complete all warning correction.
>>
>> Giulio Benetti (7):
>> rpcgen: rpc_cout: silence unused def parameter
>> rpcgen: rpc_util: add storeval args to prototype
>> rpcgen: rpc_util: add findval args to prototype
>> rpcgen: rpc_parse: add get_definition() void argument
>> rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning
>> rpcgen: rpc_hout: fix potential -Wformat-security warning
>> rpcgen: rpc_hout: fix indentation on f_print() argument separator
>>
>> tools/rpcgen/rpc_cout.c | 8 ++++----
>> tools/rpcgen/rpc_hout.c | 4 +++-
>> tools/rpcgen/rpc_parse.h | 2 +-
>> tools/rpcgen/rpc_util.h | 4 ++--
>> 4 files changed, 10 insertions(+), 8 deletions(-)
>>
> Committed (tag: nfs-utils-2-4-3-rc5)
>
> I must admit this code is actually being used... I assume they do the right thing...
>
> The rpcgen we been using is the old one that came out
> of the glibc code at https://github.com/thkukuk/rpcsvc-proto
>
> I wonder what the difference is....
I can check it and use that one as upstream maybe and update it here in
nfs-utils if you see that it makes sense.
Best regards
--
Giulio Benetti
Benetti Engineering sas
> steved.
>
next prev parent reply other threads:[~2020-01-09 14:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 21:50 [nfs-utils PATCH 0/7] silence some warning in rpcgen Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 1/7] rpcgen: rpc_cout: silence unused def parameter Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 2/7] rpcgen: rpc_util: add storeval args to prototype Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 3/7] rpcgen: rpc_util: add findval " Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 4/7] rpcgen: rpc_parse: add get_definition() void argument Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 5/7] rpcgen: rpc_cout: fix potential -Wformat-nonliteral warning Giulio Benetti
2020-01-15 16:29 ` Giulio Benetti
2020-01-16 20:07 ` Steve Dickson
2020-01-16 20:38 ` Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 6/7] rpcgen: rpc_hout: fix potential -Wformat-security warning Giulio Benetti
2020-01-03 21:50 ` [nfs-utils PATCH 7/7] rpcgen: rpc_hout: fix indentation on f_print() argument separator Giulio Benetti
2020-01-07 19:06 ` [nfs-utils PATCH 0/7] silence some warning in rpcgen Steve Dickson
2020-01-09 14:00 ` Giulio Benetti [this message]
2020-01-09 15:10 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38aa6cba-91e4-f1ec-7978-45ba4b4cf4ee@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=SteveD@RedHat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).