From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: Ulf Hansson <ulf.hansson@linaro.org>, Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-nfs@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
linux-nvme@lists.infradead.org,
virtualization@lists.linux-foundation.org,
linux-block <linux-block@vger.kernel.org>,
linux-ide@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq
Date: Mon, 25 Jan 2021 05:35:54 +0100 [thread overview]
Message-ID: <439d415f-6aed-7092-a593-0d2d490652d2@cloud.ionos.com> (raw)
In-Reply-To: <CAPDyKFoPL4drfh3efKXyhXLp6Ce+j=oHwNd9VnVP4aaKQ0zmDQ@mail.gmail.com>
On 1/22/21 10:50, Ulf Hansson wrote:
> On Fri, 22 Jan 2021 at 10:28, Guoqing Jiang
> <guoqing.jiang@cloud.ionos.com> wrote:
>>
>> We can remove 'q' from blk_execute_rq as well after the previous change
>> in blk_execute_rq_nowait.
>>
>> And more importantly it never really was needed to start with given
>> that we can trivial derive it from struct request.
>>
>> Cc: linux-scsi@vger.kernel.org
>> Cc: virtualization@lists.linux-foundation.org
>> Cc: linux-ide@vger.kernel.org
>> Cc: linux-mmc@vger.kernel.org
>> Cc: linux-nvme@lists.infradead.org
>> Cc: linux-nfs@vger.kernel.org
>> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
>
> [...]
>
>> drivers/mmc/core/block.c | 10 +++++-----
>
> [...]
>
> From mmc point of view, please add:
>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> At the moment I don't think this will conflict with any changes to
> mmc, but if that happens let's sort it then...
>
Thank you! Will resend and add your acked-by.
Guoqing
next prev parent reply other threads:[~2021-01-25 4:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 9:28 [PATCH V2 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq Guoqing Jiang
2021-01-22 9:28 ` [PATCH V2 1/2] block: remove unnecessary argument from blk_execute_rq_nowait Guoqing Jiang
2021-01-22 9:28 ` [PATCH V2 2/2] block: remove unnecessary argument from blk_execute_rq Guoqing Jiang
2021-01-22 9:50 ` Ulf Hansson
2021-01-25 4:35 ` Guoqing Jiang [this message]
2021-01-25 1:24 ` [PATCH V2 0/2] remove unused argument from blk_execute_rq_nowait and blk_execute_rq Jens Axboe
2021-01-25 4:34 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=439d415f-6aed-7092-a593-0d2d490652d2@cloud.ionos.com \
--to=guoqing.jiang@cloud.ionos.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).