From: Steve Dickson <SteveD@RedHat.com>
To: Patrick Steinhardt <ps@pks.im>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/3] file: fix missing include for PATH_MAX constant
Date: Wed, 27 Feb 2019 12:14:39 -0500 [thread overview]
Message-ID: <4ad0a829-fd7f-4829-6334-90d1ed23448f@RedHat.com> (raw)
In-Reply-To: <b867217d30569b84e098ca013c44e07e1df598fb.1549290423.git.ps@pks.im>
On 2/4/19 9:31 AM, Patrick Steinhardt wrote:
> While making use of the PATH_MAX constant, "file.c" does not include the
> "limits.h" header. While it is being transitively included via other
> headers on most platforms, it is not on e.g. musl-based systems.
>
> Add the include to fix compilation.
Committed...
steved.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> support/misc/file.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/support/misc/file.c b/support/misc/file.c
> index 4065376..e7c3819 100644
> --- a/support/misc/file.c
> +++ b/support/misc/file.c
> @@ -27,6 +27,7 @@
> #include <dirent.h>
> #include <stdlib.h>
> #include <stdbool.h>
> +#include <limits.h>
>
> #include "xlog.h"
> #include "misc.h"
>
next prev parent reply other threads:[~2019-02-27 17:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 14:31 [PATCH 1/3] configure.ac: more carefully detect availability of res_querydomain(3) Patrick Steinhardt
2019-02-04 14:31 ` [PATCH 2/3] file: fix missing include for PATH_MAX constant Patrick Steinhardt
2019-02-27 17:14 ` Steve Dickson [this message]
2019-02-04 14:31 ` [PATCH 3/3] svc_socket: fix use of undefined macro HAVE_GETRPCBYNUMBER_R Patrick Steinhardt
2019-02-27 17:16 ` Steve Dickson
2019-02-27 17:37 ` Patrick Steinhardt
2019-02-22 7:52 ` [PATCH 1/3] configure.ac: more carefully detect availability of res_querydomain(3) Patrick Steinhardt
2019-02-22 20:40 ` J. Bruce Fields
2019-02-27 16:41 ` Steve Dickson
2019-02-27 17:14 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ad0a829-fd7f-4829-6334-90d1ed23448f@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).