From: Steve Dickson <SteveD@RedHat.com>
To: Petr Vorel <petr.vorel@gmail.com>, linux-nfs@vger.kernel.org
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [nfs-utils PATCH 1/1] mountd: Add check for 'struct file_handle'
Date: Mon, 18 Nov 2019 09:02:35 -0500 [thread overview]
Message-ID: <61828832-a5ef-7aaf-07ac-e9bbf279e104@RedHat.com> (raw)
In-Reply-To: <20191117221506.32084-1-petr.vorel@gmail.com>
On 11/17/19 5:15 PM, Petr Vorel wrote:
> From: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
>
> The code to check if name_to_handle_at() is implemented generates only a
> warning but with some toolchain it doesn't fail to link (the function must be
> implemented somewhere).
> However the "struct file_handle" type is not available.
>
> So, this patch adds a check for this struct.
>
> Patch taken from buildroot distribution.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> [ pvorel: rebased from nfs-utils-1-3-4 ]
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Committed... (tag: nfs-utils-2-4-3-rc1)
steved.
> ---
> configure.ac | 1 +
> utils/mountd/cache.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 9ba9d4b5..949ff9fc 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -510,6 +510,7 @@ AC_TYPE_PID_T
> AC_TYPE_SIZE_T
> AC_HEADER_TIME
> AC_STRUCT_TM
> +AC_CHECK_TYPES([struct file_handle])
>
> dnl *************************************************************
> dnl Check for functions
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index 3861f84a..31e9507d 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -446,7 +446,7 @@ static int same_path(char *child, char *parent, int len)
> if (count_slashes(p) != count_slashes(parent))
> return 0;
>
> -#if HAVE_NAME_TO_HANDLE_AT
> +#if defined(HAVE_NAME_TO_HANDLE_AT) && defined(HAVE_STRUCT_FILE_HANDLE)
> struct {
> struct file_handle fh;
> unsigned char handle[128];
>
prev parent reply other threads:[~2019-11-18 14:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 22:15 [nfs-utils PATCH 1/1] mountd: Add check for 'struct file_handle' Petr Vorel
2019-11-18 14:02 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61828832-a5ef-7aaf-07ac-e9bbf279e104@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=maxime.hadjinlian@gmail.com \
--cc=petr.vorel@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).