From: "Benjamin Coddington" <bcodding@redhat.com>
To: "J . Bruce Fields" <bfields@fieldses.org>
Cc: "Xuewei Zhang" <xueweiz@google.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] Revert "lockd: Show pid of lockd for remote locks"
Date: Tue, 21 May 2019 16:45:26 -0400 [thread overview]
Message-ID: <A6640E39-5B5D-4CF3-8131-62F8106ED2E0@redhat.com> (raw)
In-Reply-To: <20190521155821.GD9499@fieldses.org>
On 21 May 2019, at 11:58, J . Bruce Fields wrote:
> On Mon, May 20, 2019 at 10:33:07AM -0400, Benjamin Coddington wrote:
>> This reverts most of commit b8eee0e90f97 ("lockd: Show pid of lockd for
>> remote locks"), which caused remote locks to not be differentiated between
>> remote processes for NLM.
>
> To make sure I understand: I assume a client resolves conflicts among
> its own processes before involving the server, so the server only needs
> to resolve conflicts among nlm_hosts. Is that right? So the only
> practical affect is the missing grant callbacks that Xuewei noticed?
For the linux client, I think that is correct.
> Or is my assumption not true in general? Or is it true only for some
> client implementations?
I don't know the answer here. I imagine a client could leave off checking
for local lock conflicts.
I have a set of patches that stuff nlm_lockowner into fl_owner on the
server. That allows us to set fl_pid of lockd and not lose the svid. I am
just testing them thoroughly at this point, and I'll probably get them
posted tomorrow.
Ben
next prev parent reply other threads:[~2019-05-21 20:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 14:33 [PATCH] Revert "lockd: Show pid of lockd for remote locks" Benjamin Coddington
2019-05-21 15:58 ` J . Bruce Fields
2019-05-21 20:45 ` Benjamin Coddington [this message]
2019-05-21 22:33 ` Xuewei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A6640E39-5B5D-4CF3-8131-62F8106ED2E0@redhat.com \
--to=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=xueweiz@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).