From: Chuck Lever <chuck.lever@oracle.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsref: switch the way libraries are linked.
Date: Wed, 12 Dec 2018 10:54:29 -0500 [thread overview]
Message-ID: <BEDC3A34-5C04-4AF9-852B-B8BD104A4BA4@oracle.com> (raw)
In-Reply-To: <40177ab7-bf23-7966-fbfa-9bac12d4655c@RedHat.com>
> On Dec 11, 2018, at 5:27 PM, Steve Dickson <SteveD@redhat.com> wrote:
>
>
>
> On 12/11/18 2:12 PM, Chuck Lever wrote:
>>
>>> On Dec 11, 2018, at 2:09 PM, Steve Dickson <steved@redhat.com> wrote:
>>>
>>> Link the static libs before the dynamic libs allowing
>>> the routines in the static libs to be defined
>>> by the dynamic libs
>>
>> Hi Steve, Why is this change necessary? Is there a bug report?
> No... when I enabled junctions in the Fedora rawhide (F30) I got
> a bunch of xml undefined routines
> https://koji.fedoraproject.org/koji/getfile?taskID=31408933&volume=DEFAULT&name=build.log&offset=-4000
>
> It compiled fine on f29 but not on rawhide
>
> After asking if the XML api changed, people suggested I simply
> change the order of how the static and dynamic libs are linked,
> which worked
>
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/6UIAF47S73QFLCJDWEWXKQHZTOMB5JXQ/
>
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/VK2XPHV2MELV6IRKBG2ITI6GKUBMMRQW/
OK. See also:
http://git.linux-nfs.org/?p=cel/fedfs-utils.git;a=commit;h=05d6450023265e15bdc6e6bd24c05b1586e87d1d
which is a similar change, but it hits other Makefiles as well.
I wonder why only nfsref/Makefile.am is affected for you.
> steved.
>
>>
>>
>>> Signed-off-by: Steve Dickson <steved@redhat.com>
>>> ---
>>> utils/nfsref/Makefile.am | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/utils/nfsref/Makefile.am b/utils/nfsref/Makefile.am
>>> index 44edc83..2409dd0 100644
>>> --- a/utils/nfsref/Makefile.am
>>> +++ b/utils/nfsref/Makefile.am
>>> @@ -27,9 +27,9 @@ noinst_HEADERS = nfsref.h
>>>
>>> sbin_PROGRAMS = nfsref
>>> nfsref_SOURCES = add.c lookup.c nfsref.c remove.c
>>> -LDADD = $(LIBXML2) $(LIBCAP) \
>>> - ../../support/nfs/libnfs.la \
>>> - ../../support/junction/libjunction.la
>>> +LDADD = ../../support/nfs/libnfs.la \
>>> + ../../support/junction/libjunction.la \
>>> + $(LIBXML2) $(LIBCAP)
>>>
>>> man8_MANS = nfsref.man
>>>
>>> --
>>> 2.19.2
>>>
>>
>> --
>> Chuck Lever
>>
>>
>>
--
Chuck Lever
next prev parent reply other threads:[~2018-12-12 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 19:09 [PATCH] nfsref: switch the way libraries are linked Steve Dickson
2018-12-11 19:12 ` Chuck Lever
2018-12-11 22:27 ` Steve Dickson
2018-12-12 15:54 ` Chuck Lever [this message]
2018-12-12 16:17 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BEDC3A34-5C04-4AF9-852B-B8BD104A4BA4@oracle.com \
--to=chuck.lever@oracle.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).