From: Olga Kornievskaia <aglo@umich.edu>
To: linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: v3 timeout behavior
Date: Wed, 17 Jun 2020 13:20:02 -0400 [thread overview]
Message-ID: <CAN-5tyF+xS=WV3tVAsm2g2vCQ9Q7X_bFRFOy0yEJaXx07ciVnQ@mail.gmail.com> (raw)
In-Reply-To: <CAN-5tyFGML84VX79oX-JbMsDeSW4WAA6iyBPjrd4O089iz26AQ@mail.gmail.com>
On Wed, Jun 17, 2020 at 12:04 PM Olga Kornievskaia <aglo@umich.edu> wrote:
>
> Hi folks,
>
> I have a question whether or not the current client's behaviour is
> desirable. Current behaviour: every time a v3 operation is re-sent to
> the server we update (double) the timeout. There is no distinction
> between whether or not the previous timer had expired before the
> re-sent happened.
>
> Here's the scenario:
> 1. Client sends a v3 operation
> 2. Server RST-s the connection (prior to the timeout) (eg., connection
> is immediately reset)
> 3. Client re-sends a v3 operation but the timeout is now 120sec.
>
> As a result, an application sees 2mins pause. Where as if a connection
> reset didn't change the timeout value, the client would have re-tried
> (the 3rd time) after 60secs.
>
> Question: so in sunrcp if we get errors CONNREST/CONNABORTED, should
> we skip adjusting the timeout?
This is what I have in mind:
aglo@localhost linux-nfs]$ git diff
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index 61b21daf..26be473 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -2413,7 +2413,8 @@ void rpc_force_rebind(struct rpc_clnt *clnt)
goto out_exit;
}
task->tk_action = call_encode;
- rpc_check_timeout(task);
+ if (status != -ECONNRESET && status != -ECONNABORTED)
+ rpc_check_timeout(task);
return;
out_exit:
rpc_call_rpcerror(task, status);
prev parent reply other threads:[~2020-06-17 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 16:04 v3 timeout behavior Olga Kornievskaia
2020-06-17 17:20 ` Olga Kornievskaia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN-5tyF+xS=WV3tVAsm2g2vCQ9Q7X_bFRFOy0yEJaXx07ciVnQ@mail.gmail.com' \
--to=aglo@umich.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).