From: Trond Myklebust <trondmy@hammerspace.com>
To: "aglo@umich.edu" <aglo@umich.edu>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"Anna.Schumaker@netapp.com" <Anna.Schumaker@netapp.com>
Subject: Re: [PATCH v3 0/9] Various NFSv4 state error handling fixes
Date: Sat, 21 Sep 2019 04:11:10 +0000 [thread overview]
Message-ID: <a2395c752a9c711ecfc54aebbbf6cade790a53e3.camel@hammerspace.com> (raw)
In-Reply-To: <CAN-5tyGGtASKYC2a+Y01Qr-qBBOT+ybAEokxQdZAyASpEYO+4A@mail.gmail.com>
Hi Olga
On Fri, 2019-09-20 at 17:01 -0400, Olga Kornievskaia wrote:
> Hi Trond,
>
> This version works for me. I went back to v2 and verified that it
> didn't work so whatever you did here fixed it for me.
>
That has me a little confused because I can't really see how the lack
of spinlocks could cause incorrect behaviour that consistently, however
I'm fine with the result. ☺
Thanks for the help with testing!
Trond
> On Fri, Sep 20, 2019 at 7:26 AM Trond Myklebust <trondmy@gmail.com>
> wrote:
> > Various NFSv4 fixes to ensure we handle state errors correctly. In
> > particular, we need to ensure that for COMPOUNDs like CLOSE and
> > DELEGRETURN, that may have an embedded LAYOUTRETURN, we handle the
> > layout state errors so that a retry of either the LAYOUTRETURN, or
> > the later CLOSE/DELEGRETURN does not corrupt the LAYOUTRETURN
> > reply.
> >
> > Also ensure that if we get a NFS4ERR_OLD_STATEID, then we do our
> > best to still try to destroy the state on the server, in order to
> > avoid causing state leakage.
> >
> > v2: Fix bug reports from Olga
> > - Try to avoid sending old stateids on CLOSE/OPEN_DOWNGRADE when
> > doing fully serialised NFSv4.0.
> > - Ensure LOCKU initialises the stateid correctly.
> > v3: Fix locking
> > - Ensure the patch "Handle NFS4ERR_OLD_STATEID in LOCKU" locks the
> > stateid when copying it in nfs4_alloc_unlockdata().
> >
> > Trond Myklebust (9):
> > pNFS: Ensure we do clear the return-on-close layout stateid on
> > fatal
> > errors
> > NFSv4: Clean up pNFS return-on-close error handling
> > NFSv4: Handle NFS4ERR_DELAY correctly in return-on-close
> > NFSv4: Handle RPC level errors in LAYOUTRETURN
> > NFSv4: Add a helper to increment stateid seqids
> > pNFS: Handle NFS4ERR_OLD_STATEID on layoutreturn by bumping the
> > state
> > seqid
> > NFSv4: Fix OPEN_DOWNGRADE error handling
> > NFSv4: Handle NFS4ERR_OLD_STATEID in CLOSE/OPEN_DOWNGRADE
> > NFSv4: Handle NFS4ERR_OLD_STATEID in LOCKU
> >
> > fs/nfs/nfs4_fs.h | 11 ++-
> > fs/nfs/nfs4proc.c | 209 +++++++++++++++++++++++++++++++--------
> > ------
> > fs/nfs/nfs4state.c | 16 ----
> > fs/nfs/pnfs.c | 71 +++++++++++++--
> > fs/nfs/pnfs.h | 17 +++-
> > 5 files changed, 233 insertions(+), 91 deletions(-)
> >
> > --
> > 2.21.0
> >
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2019-09-21 4:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 11:23 [PATCH v3 0/9] Various NFSv4 state error handling fixes Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 1/9] pNFS: Ensure we do clear the return-on-close layout stateid on fatal errors Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 2/9] NFSv4: Clean up pNFS return-on-close error handling Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 3/9] NFSv4: Handle NFS4ERR_DELAY correctly in return-on-close Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 4/9] NFSv4: Handle RPC level errors in LAYOUTRETURN Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 5/9] NFSv4: Add a helper to increment stateid seqids Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 6/9] pNFS: Handle NFS4ERR_OLD_STATEID on layoutreturn by bumping the state seqid Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 7/9] NFSv4: Fix OPEN_DOWNGRADE error handling Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 8/9] NFSv4: Handle NFS4ERR_OLD_STATEID in CLOSE/OPEN_DOWNGRADE Trond Myklebust
2019-09-20 11:23 ` [PATCH v3 9/9] NFSv4: Handle NFS4ERR_OLD_STATEID in LOCKU Trond Myklebust
2019-09-20 21:01 ` [PATCH v3 0/9] Various NFSv4 state error handling fixes Olga Kornievskaia
2019-09-21 4:11 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2395c752a9c711ecfc54aebbbf6cade790a53e3.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=Anna.Schumaker@netapp.com \
--cc=aglo@umich.edu \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).