From: Jeff Layton <jlayton@kernel.org>
To: Yihao Wu <wuyihao@linux.alibaba.com>,
linux-nfs@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>
Cc: Joseph Qi <joseph.qi@linux.alibaba.com>,
caspar@linux.alibaba.com,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: [PATCH v2 0/2] Fix two bugs CB_NOTIFY_LOCK failing to wake a water
Date: Thu, 16 May 2019 07:47:40 -0400 [thread overview]
Message-ID: <ac596623e5e68063e8866d9bf7cfd07eafcaf695.camel@kernel.org> (raw)
In-Reply-To: <1a3d5e35-50bc-d757-5d30-15b1c8cff9ad@linux.alibaba.com>
On Thu, 2019-05-16 at 16:01 +0800, Yihao Wu wrote:
> On 2019/5/13 9:36 PM, Jeff Layton wrote:
> > On Mon, 2019-05-13 at 14:49 +0800, Yihao Wu wrote:
> > > This patch set fix bugs related to CB_NOTIFY_LOCK. These bugs cause
> > > poor performance in locking operation. And this patchset should also fix
> > > the failure when running xfstests generic/089 on a NFSv4.1 filesystem.
> > >
> > > Yihao Wu (2):
> > > NFSv4.1: Again fix a race where CB_NOTIFY_LOCK fails to wake a waiter
> > > NFSv4.1: Fix bug only first CB_NOTIFY_LOCK is handled
> > >
> > > fs/nfs/nfs4proc.c | 31 ++++++++++++-------------------
> > > 1 file changed, 12 insertions(+), 19 deletions(-)
> > >
> >
> > Looks good to me. Nice catch, btw!
> >
> > Reviewed-by: Jeff Layton <jlayton@kernel.org>
> >
>
> Thank you for your reviewing, Jeff!
>
> And it seems I forgot to CC maintainers of fs/nfs. So I added you to the CC
> list, Trond and Anna. Does this patchset need further reviewing?
>
> Sorry to bother you.
>
This should probably go through Anna's tree, and I assume she'll pick it
up once she and/or Trond have had a chance to review it.
Thanks,
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2019-05-16 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 6:49 [PATCH v2 0/2] Fix two bugs CB_NOTIFY_LOCK failing to wake a water Yihao Wu
2019-05-13 6:57 ` [PATCH v2 1/2] NFSv4.1: Again fix a race where CB_NOTIFY_LOCK fails to wake a waiter Yihao Wu
2019-05-17 9:22 ` Joseph Qi
2019-05-17 14:04 ` Yihao Wu
2019-05-21 17:57 ` [PATCH v3 " Yihao Wu
2019-05-13 6:58 ` [PATCH v2 2/2] NFSv4.1: Fix bug only first CB_NOTIFY_LOCK is handled Yihao Wu
2019-05-13 13:36 ` [PATCH v2 0/2] Fix two bugs CB_NOTIFY_LOCK failing to wake a water Jeff Layton
2019-05-16 8:01 ` Yihao Wu
2019-05-16 11:47 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac596623e5e68063e8866d9bf7cfd07eafcaf695.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=caspar@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=wuyihao@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).