From: Xiaoli Feng <xifeng@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH v1] test/dax.sh: correct the pmd pagefault counts generated by dax-pmd
Date: Fri, 20 Mar 2020 01:16:57 -0400 (EDT) [thread overview]
Message-ID: <1667905528.17528206.1584681417038.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAPcyv4hd_N0Hef8EysL2obYiZQA9ka_=iUt+NTjaQJVbzcME6Q@mail.gmail.com>
Hi,
----- Original Message -----
> From: "Dan Williams" <dan.j.williams@intel.com>
> To: "Xiaoli Feng" <xifeng@redhat.com>
> Cc: "linux-nvdimm" <linux-nvdimm@lists.01.org>
> Sent: Friday, March 20, 2020 11:37:07 AM
> Subject: Re: [PATCH v1] test/dax.sh: correct the pmd pagefault counts generated by dax-pmd
>
> On Thu, Mar 19, 2020 at 8:19 PM Xiaoli Feng <xifeng@redhat.com> wrote:
> >
> > Hi,
> >
> > ----- Original Message -----
> > > From: "Dan Williams" <dan.j.williams@intel.com>
> > > To: "XiaoLi Feng" <xifeng@redhat.com>
> > > Cc: "linux-nvdimm" <linux-nvdimm@lists.01.org>
> > > Sent: Friday, March 20, 2020 10:36:05 AM
> > > Subject: Re: [PATCH v1] test/dax.sh: correct the pmd pagefault counts
> > > generated by dax-pmd
> > >
> > > On Thu, Mar 19, 2020 at 7:13 PM XiaoLi Feng <xifeng@redhat.com> wrote:
> > > >
> > > > From: Xiaoli Feng <xifeng@redhat.com>
> > > >
> > > > For directIO, cannot generate pmd pagefault by pread|pwrite|read|write
> > > > if do not map fd to memory. In dax-pmd.c, case 1 and case 4 each only
> > > > generate once pmd pagefault. So change the all counts from 10 to 8.
> > >
> > > What kernel are you seeing this failure on? It's passing for me on
> > > v5.6-rc.
> >
> > I test on v4.18. I will test on v5.6.
> >
>
> The tests are not backwards compatible with older kernels. If the
> current tests fail on an older kernel it means that older kernel is
> missing a backport of features / fixes from upstream. In this case the
> test was written as a regression test for kernel commit 6370740e5f8e
> ("fs/dax: Fix pmd vs pte conflict detection"). v4.18 precedes the
> Xarray conversion of the filesystem-dax interface which incurred other
> pmd behavior fixes so I'm not sure it will ever map correctly to that
> baseline.
>
> At a minimum I would say you would need to carry this change in the
> distro package for ndctl that corresponds with that v4.18 kernel.
My test kernel include the patch fs/dax: Fix pmd vs pte conflict detection.
I am checking the changes from v4.18. Thanks for the info and suggestion.
>
>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
prev parent reply other threads:[~2020-03-20 5:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 2:12 [PATCH v1] test/dax.sh: correct the pmd pagefault counts generated by dax-pmd XiaoLi Feng
2020-03-20 2:36 ` Dan Williams
2020-03-20 3:18 ` Xiaoli Feng
2020-03-20 3:37 ` Dan Williams
2020-03-20 5:16 ` Xiaoli Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1667905528.17528206.1584681417038.JavaMail.zimbra@redhat.com \
--to=xifeng@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).