From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Bart Van Assche <bvanassche@acm.org>,
ksummit <ksummit-discuss@lists.linuxfoundation.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robherring2@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Steve French <stfrench@microsoft.com>,
"Tobin C. Harding" <me@tobin.cc>
Subject: Re: [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles
Date: Fri, 13 Sep 2019 16:17:31 -0300 [thread overview]
Message-ID: <20190913161731.6e3405a3@coco.lan> (raw)
In-Reply-To: <78f67ee934f167b433517da81c6a0d3f35c4b123.camel@perches.com>
Em Fri, 13 Sep 2019 11:42:38 -0700
Joe Perches <joe@perches.com> escreveu:
> On Fri, 2019-09-13 at 15:26 +0100, Rob Herring wrote:
> > On Fri, Sep 13, 2019 at 3:12 PM Joe Perches <joe@perches.com> wrote:
> > > On Thu, 2019-09-12 at 13:01 -0700, Bart Van Assche wrote:
> > >
> > > > Another argument in favor of W=1 is that the formatting of kernel-doc
> > > > headers is checked only if W=1 is passed to make.
> > >
> > > Actually, but for the fact there are far too many
> > > to generally enable that warning right now,
> > > (an x86-64 defconfig has more than 1000)
> > > that sounds pretty reasonable to me.
>
> > It's in the 1000s on arm because W=1 turns on more checks in building
> > .dts files. There are lots of duplicates as most of the dts content is
> > as an include file (e.g. board dts includes soc dts).
>
> Yeah, dts[i] files in arm compilations are very noisy at W=1
> so moving those message types to W=2 seems sensible.
>
> $ { opt="ARCH=arm CROSS_COMPILE=arm-unknown-linux-gnueabi-" ; make $opt clean ; make $opt defconfig ; make $opt W=1 -j4 ; } > arm_make.log 2>&1
>
> $ grep -i -P 'dtsi?:.*warning' arm_make.log | wc -l
> 69164
Yeah, makes sense moving them to W=2, or to make them somehow produce
less noise.
> Just fyi: for an x86-64 defconfig with gcc 8.3
>
> $ { make clean ; make defconfig ; make -j4 W=1 ; } > make.log 2>&1
>
> There are ~300 W=1 for non kernel-doc -W<foo> warnings.
>
> $ grep -i -P -oh '\[\-W[\w\-]+\]' make.log |sort | uniq -c | sort -rn
> 163 [-Wmissing-prototypes]
> 69 [-Wunused-but-set-variable]
> 16 [-Wempty-body]
> 10 [-Wtype-limits]
> 6 [-Woverride-init]
> 2 [-Wstringop-truncation]
> 2 [-Wcast-function-type]
> 1 [-Wunused-but-set-parameter]
On my eyes, it doesn't sound too much. I suspect that,
with gcc-9, it should produce more warnings, though.
Perhaps we could "promote" most of those to W=0.
>
> And there are ~1000 kernel-doc only messages in various files
A significant amount of those warnings appear with "make htmldocs".
Not having the kernel-doc warning as part of W=0 helps to make
very hard to have them cleared.
IMHO, those should be enabled by default with W=0, at least for the
files that are included on some kernel-doc tag.
I mean, perhaps, when W=0, Kernel build could run:
$ ./scripts/kernel-doc -none $(git grep kernel-doc:: Documentation/|cut -d: -f4-|sort|uniq|grep -vE "\bsource\b")
That produces 165 warnings (against v5.3-rc4 + media -next patches).
Thanks,
Mauro
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-09-13 19:17 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 15:48 [PATCH v2 0/3] Maintainer Entry Profiles Dan Williams
2019-09-11 15:48 ` [PATCH v2 1/3] MAINTAINERS: Reclaim the P: tag for Maintainer Entry Profile Dan Williams
2019-09-13 15:37 ` [Ksummit-discuss] " Mauro Carvalho Chehab
2019-09-11 15:48 ` [PATCH v2 2/3] Maintainer Handbook: " Dan Williams
2019-09-11 17:34 ` [Ksummit-discuss] " Verma, Vishal L
2019-09-16 12:35 ` Jani Nikula
2019-10-01 13:55 ` Jonathan Corbet
2019-10-01 18:17 ` Martin K. Petersen
2019-11-07 20:13 ` Jonathan Corbet
2019-11-08 2:41 ` Dan Williams
2019-09-11 15:48 ` [PATCH v2 3/3] libnvdimm, MAINTAINERS: " Dan Williams
2019-09-11 17:42 ` [Ksummit-discuss] " Vishal Verma
2019-09-11 17:45 ` Dave Jiang
2019-09-11 18:43 ` [Ksummit-discuss] " Dan Carpenter
2019-09-11 22:11 ` Jens Axboe
2019-09-12 7:41 ` Dan Williams
2019-09-12 8:24 ` Miguel Ojeda
2019-09-12 10:18 ` Joe Perches
2019-09-12 11:02 ` Joe Perches
2019-09-12 14:17 ` Dan Williams
2019-09-12 14:51 ` Joe Perches
2019-09-12 14:42 ` Miguel Ojeda
2019-09-13 7:09 ` Jonathan Corbet
2019-09-13 11:48 ` Dan Carpenter
2019-09-13 12:18 ` Dan Williams
2019-09-13 15:00 ` Randy Dunlap
2019-09-13 15:46 ` Rob Herring
2019-09-13 16:42 ` Joe Perches
2019-09-13 19:32 ` Rob Herring
2019-09-13 17:57 ` Geert Uytterhoeven
2019-09-16 12:42 ` Jani Nikula
[not found] ` <20190917161608.GA12866@ziepe.ca>
2019-09-17 21:59 ` Dan Williams
2019-09-13 21:44 ` Martin K. Petersen
2019-09-16 7:01 ` Dan Carpenter
2019-09-16 17:08 ` Martin K. Petersen
2019-09-13 2:11 ` Aneesh Kumar K.V
2019-09-13 5:00 ` Greg KH
2019-09-11 20:30 ` Joe Perches
2019-09-11 16:40 ` [PATCH v2 0/3] Maintainer Entry Profiles Martin K. Petersen
2019-09-12 13:31 ` [Ksummit-discuss] " Bart Van Assche
2019-09-12 15:34 ` Joe Perches
2019-09-12 20:01 ` Bart Van Assche
2019-09-12 20:34 ` Joe Perches
2019-09-13 14:26 ` Rob Herring
2019-09-13 18:42 ` Joe Perches
2019-09-13 19:17 ` Mauro Carvalho Chehab [this message]
2019-09-13 20:33 ` Joe Perches
2019-09-13 12:56 ` Matthew Wilcox
2019-09-13 13:54 ` Mauro Carvalho Chehab
2019-09-13 14:59 ` Guenter Roeck
2019-09-13 22:03 ` Martin K. Petersen
2020-04-29 13:55 ` Roman Bolshakov
2019-09-12 13:10 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913161731.6e3405a3@coco.lan \
--to=mchehab@kernel.org \
--cc=bvanassche@acm.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=me@tobin.cc \
--cc=robherring2@gmail.com \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).