From: Ira Weiny <ira.weiny@intel.com>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] device-dax: make dev_dax_kmem_probe() static
Date: Fri, 10 Jul 2020 20:31:47 -0700 [thread overview]
Message-ID: <20200711033147.GA3008823@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20200707112340.9178-1-weiyongjun1@huawei.com>
On Tue, Jul 07, 2020 at 07:23:40PM +0800, Wei Yongjun wrote:
> sparse report warning as follows:
>
> drivers/dax/kmem.c:22:5: warning:
> symbol 'dev_dax_kmem_probe' was not declared. Should it be static?
>
> dev_dax_kmem_probe() is not used outside of kmem.c, so marks
> it static.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Seems ok,
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/dax/kmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c
> index 275aa5f87399..87e271668170 100644
> --- a/drivers/dax/kmem.c
> +++ b/drivers/dax/kmem.c
> @@ -19,7 +19,7 @@ static const char *kmem_name;
> /* Set if any memory will remain added when the driver will be unloaded. */
> static bool any_hotremove_failed;
>
> -int dev_dax_kmem_probe(struct device *dev)
> +static int dev_dax_kmem_probe(struct device *dev)
> {
> struct dev_dax *dev_dax = to_dev_dax(dev);
> struct resource *res = &dev_dax->region->res;
>
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-07-11 3:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 11:23 [PATCH -next] device-dax: make dev_dax_kmem_probe() static Wei Yongjun
2020-07-11 3:31 ` Ira Weiny [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-22 14:33 [PATCH -next] device-dax: Make dev_dax_kmem_probe static Yue Haibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711033147.GA3008823@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).