linux-nvdimm.lists.01.org archive mirror
 help / color / mirror / Atom feed
From: Ira Weiny <ira.weiny@intel.com>
To: Jason Yan <yanaijie@huawei.com>
Cc: akpm@linux-foundation.org, sfr@canb.auug.org.au,
	linux-nvdimm@lists.01.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] device-dax: make dev_dax_kmem_probe() static
Date: Thu, 17 Sep 2020 10:20:40 -0700	[thread overview]
Message-ID: <20200917172040.GA2541163@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20200912033901.143382-1-yanaijie@huawei.com>

On Sat, Sep 12, 2020 at 11:39:01AM +0800, Jason Yan wrote:
> This eliminates the following sparse warning:
> 
> drivers/dax/kmem.c:38:5: warning: symbol 'dev_dax_kmem_probe' was not
> declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  drivers/dax/kmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c
> index 7dcb2902e9b1..e79afbadd4e0 100644
> --- a/drivers/dax/kmem.c
> +++ b/drivers/dax/kmem.c
> @@ -35,7 +35,7 @@ static int dax_kmem_range(struct dev_dax *dev_dax, int i, struct range *r)
>  	return 0;
>  }
>  
> -int dev_dax_kmem_probe(struct dev_dax *dev_dax)
> +static int dev_dax_kmem_probe(struct dev_dax *dev_dax)
>  {
>  	int numa_node = dev_dax->target_node;
>  	struct device *dev = &dev_dax->dev;
> -- 
> 2.25.4
> _______________________________________________
> Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
> To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

      reply	other threads:[~2020-09-17 17:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12  3:39 [PATCH] device-dax: make dev_dax_kmem_probe() static Jason Yan
2020-09-17 17:20 ` Ira Weiny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917172040.GA2541163@iweiny-DESK2.sc.intel.com \
    --to=ira.weiny@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=hulkci@huawei.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=sfr@canb.auug.org.au \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).