From: riteshh <riteshh@linux.ibm.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, willy@infradead.org, jack@suse.cz,
viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org,
david@fromorbit.com, hch@lst.de, rgoldwyn@suse.de
Subject: Re: [PATCH 2/3] fsdax: Factor helper: dax_fault_actor()
Date: Wed, 7 Apr 2021 15:51:48 +0530 [thread overview]
Message-ID: <20210407102148.p2osxqohsthlrmxq@riteshh-domain> (raw)
In-Reply-To: <20210407063207.676753-3-ruansy.fnst@fujitsu.com>
On 21/04/07 02:32PM, Shiyang Ruan wrote:
> The core logic in the two dax page fault functions is similar. So, move
> the logic into a common helper function. Also, to facilitate the
> addition of new features, such as CoW, switch-case is no longer used to
> handle different iomap types.
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/dax.c | 294 ++++++++++++++++++++++++++++---------------------------
> 1 file changed, 148 insertions(+), 146 deletions(-)
Thanks for addressing comments.
A msg in cover letter acknowledging that the review comments mentioned here[1]
were addressed is helpful for everyone.
Please feel free to add.
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
[1]: https://patchwork.kernel.org/project/linux-nvdimm/patch/20210319015237.993880-3-ruansy.fnst@fujitsu.com/
-ritesh
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2021-04-07 10:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 6:32 [PATCH 0/3] fsdax: Factor helper functions to simplify the code Shiyang Ruan
2021-04-07 6:32 ` [PATCH 1/3] fsdax: Factor helpers to simplify dax fault code Shiyang Ruan
2021-04-07 10:14 ` riteshh
2021-04-07 11:13 ` Matthew Wilcox
2021-04-07 12:29 ` ruansy.fnst
2021-04-07 6:32 ` [PATCH 2/3] fsdax: Factor helper: dax_fault_actor() Shiyang Ruan
2021-04-07 10:21 ` riteshh [this message]
2021-04-07 6:32 ` [PATCH 3/3] fsdax: Output address in dax_iomap_pfn() and rename it Shiyang Ruan
2021-04-07 10:16 ` riteshh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407102148.p2osxqohsthlrmxq@riteshh-domain \
--to=riteshh@linux.ibm.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rgoldwyn@suse.de \
--cc=ruansy.fnst@fujitsu.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).