From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@lists.01.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups
Date: Fri, 23 Aug 2019 11:11:56 -0700 [thread overview]
Message-ID: <20fe41f4-80d7-521b-0517-267e3754c372@intel.com> (raw)
In-Reply-To: <156583201347.2815870.4687949334637966672.stgit@dwillia2-desk3.amr.corp.intel.com>
On 8/14/19 6:20 PM, Dan Williams wrote:
> Jeff reported a scenario where ndctl was failing to unlock DIMMs [1].
> Through the course of debug it was discovered that the security
> interface on the DIMMs was in the 'frozen' state disallowing unlock, or
> any security operation. Unfortunately the kernel only showed that the
> DIMMs were 'locked', not 'locked' and 'frozen'.
>
> Introduce a new sysfs 'frozen' attribute so that ndctl can reflect the
> "security-operations-allowed" state independently of the lock status.
> Then, followup with cleanups related to replacing a security-state-enum
> with a set of flags.
>
> [1]: https://lists.01.org/pipermail/linux-nvdimm/2019-August/022856.html
> ---
>
> Dan Williams (3):
> libnvdimm/security: Introduce a 'frozen' attribute
> libnvdimm/security: Tighten scope of nvdimm->busy vs security operations
> libnvdimm/security: Consolidate 'security' operations
>
>
> drivers/acpi/nfit/intel.c | 65 +++++++-----
> drivers/nvdimm/bus.c | 2
> drivers/nvdimm/dimm_devs.c | 134 ++++++--------------------
> drivers/nvdimm/nd-core.h | 51 ++++------
> drivers/nvdimm/security.c | 199 +++++++++++++++++++++++++-------------
> include/linux/libnvdimm.h | 9 +-
> tools/testing/nvdimm/dimm_devs.c | 19 +---
> 7 files changed, 231 insertions(+), 248 deletions(-)
>
For the series
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Thanks.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2019-08-23 18:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 1:20 [PATCH 0/3] libnvdimm/security: Enumerate the frozen state and other cleanups Dan Williams
2019-08-15 1:20 ` [PATCH 1/3] libnvdimm/security: Introduce a 'frozen' attribute Dan Williams
2019-08-16 20:34 ` Jeff Moyer
2019-08-15 1:20 ` [PATCH 2/3] libnvdimm/security: Tighten scope of nvdimm->busy vs security operations Dan Williams
2019-08-16 20:49 ` Jeff Moyer
2019-08-16 21:02 ` Dan Williams
2019-08-19 14:32 ` Jeff Moyer
2019-08-15 1:20 ` [PATCH 3/3] libnvdimm/security: Consolidate 'security' operations Dan Williams
2019-08-16 20:51 ` Jeff Moyer
2019-08-23 18:11 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20fe41f4-80d7-521b-0517-267e3754c372@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).