From: Jane Chu <jane.chu@oracle.com>
To: Coly Li <colyli@suse.de>,
dan.j.williams@intel.com, linux-nvdimm@lists.01.org
Cc: msuchanek@suse.com, ailiopoulos@suse.com,
Jan Kara <jack@suse.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Subject: Re: [PATCH v3] dax: print error message by pr_info() in __generic_fsdax_supported()
Date: Mon, 27 Jul 2020 10:02:11 -0700 [thread overview]
Message-ID: <7366fc46-48ee-8c9a-c8f2-8e4e03919880@oracle.com> (raw)
In-Reply-To: <20200725162450.95999-1-colyli@suse.de>
Hi,
On 7/25/2020 9:24 AM, Coly Li wrote:
> It is not simple to make dax_supported() from struct dax_operations
> or __generic_fsdax_supported() to return exact failure type right now.
> So the simplest fix is to use pr_info() to print all the error messages
> inside __generic_fsdax_supported(). Then users may find informative clue
> from the kernel message at least.
I happen to notice that some servers set their printk levels at 4 by
default to minimize console messages:
# cat /proc/sys/kernel/printk
4 4 1 7
So I'm wondering if you would consider pr_error() instead of pr_info() ?
thanks,
-jane
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
next prev parent reply other threads:[~2020-07-27 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 16:24 [PATCH v3] dax: print error message by pr_info() in __generic_fsdax_supported() Coly Li
2020-07-27 17:02 ` Jane Chu [this message]
2020-07-27 21:44 ` Jan Kara
2020-07-27 23:28 ` Jane Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7366fc46-48ee-8c9a-c8f2-8e4e03919880@oracle.com \
--to=jane.chu@oracle.com \
--cc=ailiopoulos@suse.com \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.com \
--cc=linux-nvdimm@lists.01.org \
--cc=msuchanek@suse.com \
--cc=pankaj.gupta.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).